Re: [PATCH] smp: smp_call_on_cpu(): use INIT_WORK_ONSTACK() for automatic work_struct

2016-09-23 Thread Peter Zijlstra
On Thu, Sep 22, 2016 at 09:15:52PM +0200, Nicolai Stange wrote: > One minor question regarding your patch though: it hasn't got a > destroy_work_on_stack(). Isn't one needed because of > INIT_WORK_ONSTACK() -> __INIT_WORK() -> __init_work() -> > debug_object_init_on_stack() ? > At least work_o

Re: [PATCH] smp: smp_call_on_cpu(): use INIT_WORK_ONSTACK() for automatic work_struct

2016-09-22 Thread Nicolai Stange
Peter Zijlstra writes: > On Thu, Sep 22, 2016 at 08:17:58PM +0200, Nicolai Stange wrote: >> This new warning >> >> INFO: trying to register non-static key. >> the code is fine but needs lockdep annotation. >> turning off the locking correctness validator. >> CPU: 0 PID: 82 Comm: kworker/

Re: [PATCH] smp: smp_call_on_cpu(): use INIT_WORK_ONSTACK() for automatic work_struct

2016-09-22 Thread Peter Zijlstra
On Thu, Sep 22, 2016 at 08:17:58PM +0200, Nicolai Stange wrote: > This new warning > > INFO: trying to register non-static key. > the code is fine but needs lockdep annotation. > turning off the locking correctness validator. > CPU: 0 PID: 82 Comm: kworker/0:1 Not tainted 4.8.0-rc6+ #360 >

[PATCH] smp: smp_call_on_cpu(): use INIT_WORK_ONSTACK() for automatic work_struct

2016-09-22 Thread Nicolai Stange
This new warning INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 82 Comm: kworker/0:1 Not tainted 4.8.0-rc6+ #360 Hardware name: Dell Inc. Latitude E6540/0725FP, BIOS A10 06/26/2014 Workq