[PATCH] staging: fpga manager: fix array_size.cocci warnings
drivers/staging/fpga/altera.c:368:33-34: WARNING: Use ARRAY_SIZE Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element Semantic patch information: This makes an effort to find cases where ARRAY_SIZE can be used such as where there is a division of sizeof the array by the sizeof its first element or by any indexed element or the element type. It replaces the division of the two sizeofs by ARRAY_SIZE. Generated by: scripts/coccinelle/misc/array_size.cocci CC: Alan Tull Signed-off-by: Fengguang Wu --- altera.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/fpga/altera.c +++ b/drivers/staging/fpga/altera.c @@ -365,7 +365,7 @@ static int altera_fpga_cfg_mode_get(stru msel >>= ALTERA_FPGAMGR_STAT_MSEL_SHIFT; /* Check that this MSEL setting is supported */ - if ((msel >= sizeof(cfgmgr_modes)/sizeof(struct cfgmgr_mode)) || + if ((msel >= ARRAY_SIZE(cfgmgr_modes)) || !cfgmgr_modes[msel].valid) return -EINVAL; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] staging: fpga manager: fix array_size.cocci warnings
drivers/staging/fpga/altera.c:368:33-34: WARNING: Use ARRAY_SIZE Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element Semantic patch information: This makes an effort to find cases where ARRAY_SIZE can be used such as where there is a division of sizeof the array by the sizeof its first element or by any indexed element or the element type. It replaces the division of the two sizeofs by ARRAY_SIZE. Generated by: scripts/coccinelle/misc/array_size.cocci CC: Alan Tull at...@opensource.altera.com Signed-off-by: Fengguang Wu fengguang...@intel.com --- altera.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/fpga/altera.c +++ b/drivers/staging/fpga/altera.c @@ -365,7 +365,7 @@ static int altera_fpga_cfg_mode_get(stru msel = ALTERA_FPGAMGR_STAT_MSEL_SHIFT; /* Check that this MSEL setting is supported */ - if ((msel = sizeof(cfgmgr_modes)/sizeof(struct cfgmgr_mode)) || + if ((msel = ARRAY_SIZE(cfgmgr_modes)) || !cfgmgr_modes[msel].valid) return -EINVAL; -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
