Re: [PATCH] staging: ks7010: clean function declaration in ks_hostif.c up

[Greg KH]

On Sun, Sep 18, 2016 at 07:07:50PM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/staging/ks7010/ks_wlan_net.c:3392:6: warning: no previous prototype 
> for 'send_packet_complete' [-Wmissing-prototypes]
> 
> In fact, this function is declared in
> drivers/staging/ks7010/ks_hostif.c, but should be
> declared in a header file. thus can be recognized in other file.
> 
> So this patch moves the declaration into
> drivers/staging/ks7010/ks_wlan.h.
> 
> Signed-off-by: Baoyou Xie 

You are sending me multiple patches for the same driver, yet no
ordering, so these don't apply for me at all.  Please fix this up and
resend, I've dropped all of the ones from you for this driver now.

greg k-h

Re: [PATCH] staging: ks7010: clean function declaration in ks_hostif.c up

[Greg KH]

On Sun, Sep 18, 2016 at 07:07:50PM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/staging/ks7010/ks_wlan_net.c:3392:6: warning: no previous prototype 
> for 'send_packet_complete' [-Wmissing-prototypes]
> 
> In fact, this function is declared in
> drivers/staging/ks7010/ks_hostif.c, but should be
> declared in a header file. thus can be recognized in other file.
> 
> So this patch moves the declaration into
> drivers/staging/ks7010/ks_wlan.h.
> 
> Signed-off-by: Baoyou Xie 

You are sending me multiple patches for the same driver, yet no
ordering, so these don't apply for me at all.  Please fix this up and
resend, I've dropped all of the ones from you for this driver now.

greg k-h

[PATCH] staging: ks7010: clean function declaration in ks_hostif.c up

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/staging/ks7010/ks_wlan_net.c:3392:6: warning: no previous prototype for 
'send_packet_complete' [-Wmissing-prototypes]

In fact, this function is declared in
drivers/staging/ks7010/ks_hostif.c, but should be
declared in a header file. thus can be recognized in other file.

So this patch moves the declaration into
drivers/staging/ks7010/ks_wlan.h.

Signed-off-by: Baoyou Xie 
---
 drivers/staging/ks7010/ks_hostif.c | 1 -
 drivers/staging/ks7010/ks_wlan.h   | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index c5fc31c..67241c5 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -24,7 +24,6 @@ extern int ks_wlan_hw_tx(struct ks_wlan_private *priv, void 
*p,
 unsigned long size,
 void (*complete_handler) (void *arg1, void *arg2),
 void *arg1, void *arg2);
-extern void send_packet_complete(void *, void *);
 
 extern void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv);
 extern int ks_wlan_hw_power_save(struct ks_wlan_private *priv);
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index f05dc01..bec918f 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -503,3 +503,5 @@ extern int ks_wlan_net_start(struct net_device *dev);
 extern int ks_wlan_net_stop(struct net_device *dev);

+void send_packet_complete(void *, void *);
+
 #endif /* _KS_WLAN_H */
2.7.4

[PATCH] staging: ks7010: clean function declaration in ks_hostif.c up

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/staging/ks7010/ks_wlan_net.c:3392:6: warning: no previous prototype for 
'send_packet_complete' [-Wmissing-prototypes]

In fact, this function is declared in
drivers/staging/ks7010/ks_hostif.c, but should be
declared in a header file. thus can be recognized in other file.

So this patch moves the declaration into
drivers/staging/ks7010/ks_wlan.h.

Signed-off-by: Baoyou Xie 
---
 drivers/staging/ks7010/ks_hostif.c | 1 -
 drivers/staging/ks7010/ks_wlan.h   | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index c5fc31c..67241c5 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -24,7 +24,6 @@ extern int ks_wlan_hw_tx(struct ks_wlan_private *priv, void 
*p,
 unsigned long size,
 void (*complete_handler) (void *arg1, void *arg2),
 void *arg1, void *arg2);
-extern void send_packet_complete(void *, void *);
 
 extern void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv);
 extern int ks_wlan_hw_power_save(struct ks_wlan_private *priv);
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index f05dc01..bec918f 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -503,3 +503,5 @@ extern int ks_wlan_net_start(struct net_device *dev);
 extern int ks_wlan_net_stop(struct net_device *dev);

+void send_packet_complete(void *, void *);
+
 #endif /* _KS_WLAN_H */
2.7.4