Re: [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print

2017-08-17 Thread Greg Kroah-Hartman 
On Sun, Aug 06, 2017 at 12:12:47AM +0800, 张树荣 wrote:
> Replace hard-coded function names in strings with "%s", __func__
> in the olpc_dcon.c file. Issue found by checkpatch.pl.

Your subject line is too long :(

> 
> Signed-off-by: Marvin Zhang 
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..429ca58 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
>   if (ret)
>   return ret;
> 
> - pr_info("dcon_freeze_store: %lu\n", output);
> + pr_info("%s: %lu\n",__func__, output);

Your patch is corrupted and can not be applied :(

Please fix up and resend.

thanks,

greg k-h

Re: [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print

2017-08-17 Thread Greg Kroah-Hartman 
On Sun, Aug 06, 2017 at 12:12:47AM +0800, 张树荣 wrote:
> Replace hard-coded function names in strings with "%s", __func__
> in the olpc_dcon.c file. Issue found by checkpatch.pl.

Your subject line is too long :(

> 
> Signed-off-by: Marvin Zhang 
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..429ca58 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
>   if (ret)
>   return ret;
> 
> - pr_info("dcon_freeze_store: %lu\n", output);
> + pr_info("%s: %lu\n",__func__, output);

Your patch is corrupted and can not be applied :(

Please fix up and resend.

thanks,

greg k-h

[PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print

2017-08-05 Thread 张树荣 
Replace hard-coded function names in strings with "%s", __func__
in the olpc_dcon.c file. Issue found by checkpatch.pl.

Signed-off-by: Marvin Zhang 
---
 drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
b/drivers/staging/olpc_dcon/olpc_dcon.c
index f7f3a78..429ca58 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
  if (ret)
  return ret;

- pr_info("dcon_freeze_store: %lu\n", output);
+ pr_info("%s: %lu\n",__func__, output);

  switch (output) {
  case 0:
-- 
2.7.4

[PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print

2017-08-05 Thread 张树荣 
Replace hard-coded function names in strings with "%s", __func__
in the olpc_dcon.c file. Issue found by checkpatch.pl.

Signed-off-by: Marvin Zhang 
---
 drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
b/drivers/staging/olpc_dcon/olpc_dcon.c
index f7f3a78..429ca58 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
  if (ret)
  return ret;

- pr_info("dcon_freeze_store: %lu\n", output);
+ pr_info("%s: %lu\n",__func__, output);

  switch (output) {
  case 0:
-- 
2.7.4