Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
Hi, On Wed, Oct 31, 2012 at 11:07:44AM -0400, Alan Stern wrote: > On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > > > On Wed, Oct 31 2012, Felipe Balbi wrote: > > > nevertheless, I should be receiving a patch right about now removing > > > that file. Alan, care to send a patch for that ? > > > > I have some other stuff to remove as well, so I can take care of it, so > > Alan can spend his time on something more important. > > I'm happy to have Michal remove g_file_storage. That way, he gets to > deal with any complaints. :-) heh, good point :-) -- balbi signature.asc Description: Digital signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > On Wed, Oct 31 2012, Felipe Balbi wrote: > > nevertheless, I should be receiving a patch right about now removing > > that file. Alan, care to send a patch for that ? > > I have some other stuff to remove as well, so I can take care of it, so > Alan can spend his time on something more important. I'm happy to have Michal remove g_file_storage. That way, he gets to deal with any complaints. :-) Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
Hi, On Wed, Oct 31, 2012 at 01:55:03PM +0100, Michal Nazarewicz wrote: > On Wed, Oct 31 2012, Felipe Balbi wrote: > > nevertheless, I should be receiving a patch right about now removing > > that file. Alan, care to send a patch for that ? > > I have some other stuff to remove as well, so I can take care of it, so > Alan can spend his time on something more important. that's up to you guys, I just need the patch removing what we committed to remove ;-) Either way is fine by me :-) cheers ps: thanks for volunteering :-) -- balbi signature.asc Description: Digital signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, Oct 31 2012, Felipe Balbi wrote: > nevertheless, I should be receiving a patch right about now removing > that file. Alan, care to send a patch for that ? I have some other stuff to remove as well, so I can take care of it, so Alan can spend his time on something more important. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz(o o) ooo +--ooO--(_)--Ooo-- pgpXEcn53TGWi.pgp Description: PGP signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
Hi, On Wed, Oct 24, 2012 at 08:47:04PM +0200, Michal Nazarewicz wrote: > > On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: > >> At first it looks strange as FSG does not use composite, but yeah: > > On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: > > Yeah. However, it should be removed in v3.8 anyway :) > > Yep, that's what feature-removal-schedule.txt says. :] except that it was dropped by commit 9c0ece069b32e8e122aea71aa47181c10eb85ba7 nevertheless, I should be receiving a patch right about now removing that file. Alan, care to send a patch for that ? -- balbi signature.asc Description: Digital signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
Hi, On Wed, Oct 24, 2012 at 08:47:04PM +0200, Michal Nazarewicz wrote: On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: At first it looks strange as FSG does not use composite, but yeah: On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: Yeah. However, it should be removed in v3.8 anyway :) Yep, that's what feature-removal-schedule.txt says. :] except that it was dropped by commit 9c0ece069b32e8e122aea71aa47181c10eb85ba7 nevertheless, I should be receiving a patch right about now removing that file. Alan, care to send a patch for that ? -- balbi signature.asc Description: Digital signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, Oct 31 2012, Felipe Balbi ba...@ti.com wrote: nevertheless, I should be receiving a patch right about now removing that file. Alan, care to send a patch for that ? I have some other stuff to remove as well, so I can take care of it, so Alan can spend his time on something more important. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz(o o) ooo +email/xmpp: m...@google.com--ooO--(_)--Ooo-- pgpXEcn53TGWi.pgp Description: PGP signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
Hi, On Wed, Oct 31, 2012 at 01:55:03PM +0100, Michal Nazarewicz wrote: On Wed, Oct 31 2012, Felipe Balbi ba...@ti.com wrote: nevertheless, I should be receiving a patch right about now removing that file. Alan, care to send a patch for that ? I have some other stuff to remove as well, so I can take care of it, so Alan can spend his time on something more important. that's up to you guys, I just need the patch removing what we committed to remove ;-) Either way is fine by me :-) cheers ps: thanks for volunteering :-) -- balbi signature.asc Description: Digital signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, 31 Oct 2012, Michal Nazarewicz wrote: On Wed, Oct 31 2012, Felipe Balbi ba...@ti.com wrote: nevertheless, I should be receiving a patch right about now removing that file. Alan, care to send a patch for that ? I have some other stuff to remove as well, so I can take care of it, so Alan can spend his time on something more important. I'm happy to have Michal remove g_file_storage. That way, he gets to deal with any complaints. :-) Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
Hi, On Wed, Oct 31, 2012 at 11:07:44AM -0400, Alan Stern wrote: On Wed, 31 Oct 2012, Michal Nazarewicz wrote: On Wed, Oct 31 2012, Felipe Balbi ba...@ti.com wrote: nevertheless, I should be receiving a patch right about now removing that file. Alan, care to send a patch for that ? I have some other stuff to remove as well, so I can take care of it, so Alan can spend his time on something more important. I'm happy to have Michal remove g_file_storage. That way, he gets to deal with any complaints. :-) heh, good point :-) -- balbi signature.asc Description: Digital signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
> On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: >> At first it looks strange as FSG does not use composite, but yeah: On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: > Yeah. However, it should be removed in v3.8 anyway :) Yep, that's what feature-removal-schedule.txt says. :] -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz(o o) ooo +--ooO--(_)--Ooo-- pgpFjWBXHyEmB.pgp Description: PGP signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: > At first it looks strange as FSG does not use composite, but yeah: Yeah. However, it should be removed in v3.8 anyway :) > Acked-by: Michal Nazarewicz Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: > From: Sebastian Andrzej Siewior > Date: Wed, 24 Oct 2012 16:40:10 +0200 > > found by randconfig, Randy Dunlap and Stephen Rothwell: > > |drivers/built-in.o: In function `fsg_setup': > |file_storage.c:(.text+0x24db7c): undefined reference to > `usb_gadget_config_buf' > |file_storage.c:(.text+0x24db98): undefined reference to > `usb_gadget_get_string' > |drivers/built-in.o: In function `fsg_bind': > |file_storage.c:(.init.text+0xee42): undefined reference to > `usb_ep_autoconfig_reset' > |file_storage.c:(.init.text+0xee51): undefined reference to > `usb_ep_autoconfig' > |file_storage.c:(.init.text+0xee73): undefined reference to > `usb_ep_autoconfig' > |file_storage.c:(.init.text+0xee9e): undefined reference to > `usb_ep_autoconfig' > > Signed-off-by: Sebastian Andrzej Siewior At first it looks strange as FSG does not use composite, but yeah: Acked-by: Michal Nazarewicz > --- > for v3.7 please. > > drivers/usb/gadget/Kconfig |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index bbcec83..66bc3ab 100644 > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -737,6 +737,7 @@ config USB_FUNCTIONFS_GENERIC > > config USB_FILE_STORAGE > tristate "File-backed Storage Gadget (DEPRECATED)" > + select USB_LIBCOMPOSITE > depends on BLOCK > help > The File-backed Storage Gadget acts as a USB Mass Storage -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz(o o) ooo +--ooO--(_)--Ooo-- pgpm3ktKU205V.pgp Description: PGP signature
[PATCH] usb/gadget: let file storage gadget select libcomposite
From: Sebastian Andrzej Siewior Date: Wed, 24 Oct 2012 16:40:10 +0200 found by randconfig, Randy Dunlap and Stephen Rothwell: |drivers/built-in.o: In function `fsg_setup': |file_storage.c:(.text+0x24db7c): undefined reference to `usb_gadget_config_buf' |file_storage.c:(.text+0x24db98): undefined reference to `usb_gadget_get_string' |drivers/built-in.o: In function `fsg_bind': |file_storage.c:(.init.text+0xee42): undefined reference to `usb_ep_autoconfig_reset' |file_storage.c:(.init.text+0xee51): undefined reference to `usb_ep_autoconfig' |file_storage.c:(.init.text+0xee73): undefined reference to `usb_ep_autoconfig' |file_storage.c:(.init.text+0xee9e): undefined reference to `usb_ep_autoconfig' Signed-off-by: Sebastian Andrzej Siewior --- for v3.7 please. drivers/usb/gadget/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index bbcec83..66bc3ab 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -737,6 +737,7 @@ config USB_FUNCTIONFS_GENERIC config USB_FILE_STORAGE tristate "File-backed Storage Gadget (DEPRECATED)" + select USB_LIBCOMPOSITE depends on BLOCK help The File-backed Storage Gadget acts as a USB Mass Storage -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] usb/gadget: let file storage gadget select libcomposite
From: Sebastian Andrzej Siewior bige...@linutronix.de Date: Wed, 24 Oct 2012 16:40:10 +0200 found by randconfig, Randy Dunlap and Stephen Rothwell: |drivers/built-in.o: In function `fsg_setup': |file_storage.c:(.text+0x24db7c): undefined reference to `usb_gadget_config_buf' |file_storage.c:(.text+0x24db98): undefined reference to `usb_gadget_get_string' |drivers/built-in.o: In function `fsg_bind': |file_storage.c:(.init.text+0xee42): undefined reference to `usb_ep_autoconfig_reset' |file_storage.c:(.init.text+0xee51): undefined reference to `usb_ep_autoconfig' |file_storage.c:(.init.text+0xee73): undefined reference to `usb_ep_autoconfig' |file_storage.c:(.init.text+0xee9e): undefined reference to `usb_ep_autoconfig' Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- for v3.7 please. drivers/usb/gadget/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index bbcec83..66bc3ab 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -737,6 +737,7 @@ config USB_FUNCTIONFS_GENERIC config USB_FILE_STORAGE tristate File-backed Storage Gadget (DEPRECATED) + select USB_LIBCOMPOSITE depends on BLOCK help The File-backed Storage Gadget acts as a USB Mass Storage -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: From: Sebastian Andrzej Siewior bige...@linutronix.de Date: Wed, 24 Oct 2012 16:40:10 +0200 found by randconfig, Randy Dunlap and Stephen Rothwell: |drivers/built-in.o: In function `fsg_setup': |file_storage.c:(.text+0x24db7c): undefined reference to `usb_gadget_config_buf' |file_storage.c:(.text+0x24db98): undefined reference to `usb_gadget_get_string' |drivers/built-in.o: In function `fsg_bind': |file_storage.c:(.init.text+0xee42): undefined reference to `usb_ep_autoconfig_reset' |file_storage.c:(.init.text+0xee51): undefined reference to `usb_ep_autoconfig' |file_storage.c:(.init.text+0xee73): undefined reference to `usb_ep_autoconfig' |file_storage.c:(.init.text+0xee9e): undefined reference to `usb_ep_autoconfig' Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de At first it looks strange as FSG does not use composite, but yeah: Acked-by: Michal Nazarewicz min...@mina86.com --- for v3.7 please. drivers/usb/gadget/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index bbcec83..66bc3ab 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -737,6 +737,7 @@ config USB_FUNCTIONFS_GENERIC config USB_FILE_STORAGE tristate File-backed Storage Gadget (DEPRECATED) + select USB_LIBCOMPOSITE depends on BLOCK help The File-backed Storage Gadget acts as a USB Mass Storage -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz(o o) ooo +email/xmpp: m...@google.com--ooO--(_)--Ooo-- pgpm3ktKU205V.pgp Description: PGP signature
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: At first it looks strange as FSG does not use composite, but yeah: Yeah. However, it should be removed in v3.8 anyway :) Acked-by: Michal Nazarewicz min...@mina86.com Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb/gadget: let file storage gadget select libcomposite
On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: At first it looks strange as FSG does not use composite, but yeah: On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: Yeah. However, it should be removed in v3.8 anyway :) Yep, that's what feature-removal-schedule.txt says. :] -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz(o o) ooo +email/xmpp: m...@google.com--ooO--(_)--Ooo-- pgpFjWBXHyEmB.pgp Description: PGP signature
