Re: [PATCH] usb: isp1760: Use kasprintf

2018-03-07 Thread Himanshu Jha
On Wed, Mar 07, 2018 at 08:20:54PM +0200, Andy Shevchenko wrote: > On Wed, Mar 7, 2018 at 8:08 PM, Himanshu Jha > wrote: > > Use kasprintf instead of combination of kmalloc and sprintf and > > therefore avoid unnecessary computation of string length. > > >

Re: [PATCH] usb: isp1760: Use kasprintf

2018-03-07 Thread Himanshu Jha
On Wed, Mar 07, 2018 at 08:20:54PM +0200, Andy Shevchenko wrote: > On Wed, Mar 7, 2018 at 8:08 PM, Himanshu Jha > wrote: > > Use kasprintf instead of combination of kmalloc and sprintf and > > therefore avoid unnecessary computation of string length. > > > devname = dev_name(isp->dev); >

Re: [PATCH] usb: isp1760: Use kasprintf

2018-03-07 Thread Andy Shevchenko
On Wed, Mar 7, 2018 at 8:08 PM, Himanshu Jha wrote: > Use kasprintf instead of combination of kmalloc and sprintf and > therefore avoid unnecessary computation of string length. > devname = dev_name(isp->dev); Do you still need this temporary variable? > -

Re: [PATCH] usb: isp1760: Use kasprintf

2018-03-07 Thread Andy Shevchenko
On Wed, Mar 7, 2018 at 8:08 PM, Himanshu Jha wrote: > Use kasprintf instead of combination of kmalloc and sprintf and > therefore avoid unnecessary computation of string length. > devname = dev_name(isp->dev); Do you still need this temporary variable? > - udc->irqname =

[PATCH] usb: isp1760: Use kasprintf

2018-03-07 Thread Himanshu Jha
Use kasprintf instead of combination of kmalloc and sprintf and therefore avoid unnecessary computation of string length. Signed-off-by: Himanshu Jha --- drivers/usb/isp1760/isp1760-udc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH] usb: isp1760: Use kasprintf

2018-03-07 Thread Himanshu Jha
Use kasprintf instead of combination of kmalloc and sprintf and therefore avoid unnecessary computation of string length. Signed-off-by: Himanshu Jha --- drivers/usb/isp1760/isp1760-udc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/isp1760/isp1760-udc.c