Re: [PATCH] video: fbdev: udlfb: Fix use after free on dlfb_usb_probe error path

2017-08-21 Thread Bartlomiej Zolnierkiewicz
On Friday, August 11, 2017 03:59:01 PM Anton Vasilyev wrote: > If dlfb_usb_probe drops to error path then there is only one > kref_init() call and no kref_get(), so second kref_put() leads to > use after free. > > The patch removes superfluous kref_put on dlfb_usb_probe error path. > > Found by L

[PATCH] video: fbdev: udlfb: Fix use after free on dlfb_usb_probe error path

2017-08-11 Thread Anton Vasilyev
If dlfb_usb_probe drops to error path then there is only one kref_init() call and no kref_get(), so second kref_put() leads to use after free. The patch removes superfluous kref_put on dlfb_usb_probe error path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton