Re: [PATCH] vsprintf: replace space with readable '=' before crng is ready

2018-02-13 Thread Tobin C. Harding
On Tue, Feb 13, 2018 at 08:16:57AM +0100, Rasmus Villemoes wrote: > On 13 February 2018 at 07:20, Shunyong Yang > wrote: > > > > > This patch replaces space with readable "=" when output needs padding. > > Following is the output after applying the patch, > > > Suggested-by: Rasmus Villemoes >

Re: [PATCH] vsprintf: replace space with readable '=' before crng is ready

2018-02-12 Thread Yang, Shunyong
Hi, Rasmus, On Tue, 2018-02-13 at 08:16 +0100, Rasmus Villemoes wrote: > On 13 February 2018 at 07:20, Shunyong Yang > wrote: > > > > > > > This patch replaces space with readable "=" when output needs > > padding. > > Following is the output after applying the patch, > > > > Suggested-by: Ra

Re: [PATCH] vsprintf: replace space with readable '=' before crng is ready

2018-02-12 Thread Rasmus Villemoes
On 13 February 2018 at 07:20, Shunyong Yang wrote: > > This patch replaces space with readable "=" when output needs padding. > Following is the output after applying the patch, > Suggested-by: Rasmus Villemoes > > if (unlikely(!have_filled_random_ptr_key)) { > + char *ptr

[PATCH] vsprintf: replace space with readable '=' before crng is ready

2018-02-12 Thread Shunyong Yang
Before crng is ready, output of "%p" composes of "(ptrval)" and left padding spaces for alignment as no random address can be generated. This seems a little strange when default string width is larger than strlen("(ptrval)"). For example, when irq domain names are built with "%p", the nodes under