Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error
Hi Arvind 12.08.2017, 11:38, "Arvind Yadav": > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Fix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav Looks good to me, thank you kernel-janitors@ please queue this up Acked-by: Evgeniy Polyakov > --- > drivers/w1/masters/ds2490.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c > index 46ccb2f..a02da9a 100644 > --- a/drivers/w1/masters/ds2490.c > +++ b/drivers/w1/masters/ds2490.c > @@ -1088,7 +1088,7 @@ static void ds_disconnect(struct usb_interface *intf) > kfree(dev); > } > > -static struct usb_device_id ds_id_table [] = { > +static const struct usb_device_id ds_id_table[] = { > { USB_DEVICE(0x04fa, 0x2490) }, > { }, > }; > -- > 2.7.4
Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error
Hi Arvind 12.08.2017, 11:38, "Arvind Yadav" : > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Fix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav Looks good to me, thank you kernel-janitors@ please queue this up Acked-by: Evgeniy Polyakov > --- > drivers/w1/masters/ds2490.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c > index 46ccb2f..a02da9a 100644 > --- a/drivers/w1/masters/ds2490.c > +++ b/drivers/w1/masters/ds2490.c > @@ -1088,7 +1088,7 @@ static void ds_disconnect(struct usb_interface *intf) > kfree(dev); > } > > -static struct usb_device_id ds_id_table [] = { > +static const struct usb_device_id ds_id_table[] = { > { USB_DEVICE(0x04fa, 0x2490) }, > { }, > }; > -- > 2.7.4
[PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav--- drivers/w1/masters/ds2490.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c index 46ccb2f..a02da9a 100644 --- a/drivers/w1/masters/ds2490.c +++ b/drivers/w1/masters/ds2490.c @@ -1088,7 +1088,7 @@ static void ds_disconnect(struct usb_interface *intf) kfree(dev); } -static struct usb_device_id ds_id_table [] = { +static const struct usb_device_id ds_id_table[] = { { USB_DEVICE(0x04fa, 0x2490) }, { }, }; -- 2.7.4
[PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav --- drivers/w1/masters/ds2490.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c index 46ccb2f..a02da9a 100644 --- a/drivers/w1/masters/ds2490.c +++ b/drivers/w1/masters/ds2490.c @@ -1088,7 +1088,7 @@ static void ds_disconnect(struct usb_interface *intf) kfree(dev); } -static struct usb_device_id ds_id_table [] = { +static const struct usb_device_id ds_id_table[] = { { USB_DEVICE(0x04fa, 0x2490) }, { }, }; -- 2.7.4