Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-15 Thread Peter Zijlstra
On Thu, Feb 15, 2018 at 10:44:44AM -0700, Jerry Hoemann wrote: > Is your desire to remove of the firmware callback/spinlock in hpwdt_pretimeout > related to David Woodhouse patch set: That's the work that made us find this code, but no, even without that, code like that is entirely dodgy. NMI code

Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-15 Thread Ingo Molnar
* Jerry Hoemann wrote: > On Thu, Feb 15, 2018 at 12:17:04AM +0100, Ingo Molnar wrote: > > > > * Jerry Hoemann wrote: > > > > > > > > Ingo, > > > > > > I have a patch set under review that brings hpwdt into compliance > > > with the watchdog core. > > > > > > One of the changes removes the

Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-15 Thread Jerry Hoemann
On Thu, Feb 15, 2018 at 12:17:04AM +0100, Ingo Molnar wrote: > > * Jerry Hoemann wrote: > > > > > Ingo, > > > > I have a patch set under review that brings hpwdt into compliance > > with the watchdog core. > > > > One of the changes removes the callback into firmware in hpwdt_pretimeout > > a

Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-14 Thread Ingo Molnar
* Jerry Hoemann wrote: > > Ingo, > > I have a patch set under review that brings hpwdt into compliance > with the watchdog core. > > One of the changes removes the callback into firmware in hpwdt_pretimeout > and its associated spinlock. > > https://lkml.org/lkml/2018/2/12/30 drivers/watch

Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-14 Thread Jerry Hoemann
spinlock use can be removed as well. > > > > Thanks, > > > > Ingo > > > > > > > From b038428a739a3fcf0b9678305c131f60af7422ca Mon Sep 17 00:00:00 2001 > > From: Ingo Molnar > > Date: Wed, 14 Feb 20

Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-14 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Wed, Feb 14, 2018 at 10:31:59AM +0100, Ingo Molnar wrote: > > Because in this particular case it does not appear to be so: the reason for > > the > > BIOS/firmware call appears to be to determine how we nmi_panic() after > > receiving > > an NMI that no other NMI

Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-14 Thread Borislav Petkov
changed, 4 insertions(+), 26 deletions(-) > > As a bonus the spinlock use can be removed as well. > > Thanks, > > Ingo > > > > From b038428a739a3fcf0b9678305c131f60af7422ca Mon Sep 17 00:00:00 2001 > From: Ingo Molnar > Date: Wed, 14 Feb 2018 10:24:41 +0100

Re: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-14 Thread Peter Zijlstra
On Wed, Feb 14, 2018 at 10:31:59AM +0100, Ingo Molnar wrote: > Because in this particular case it does not appear to be so: the reason for > the > BIOS/firmware call appears to be to determine how we nmi_panic() after > receiving > an NMI that no other NMI handler handled: with a passive-aggres

[PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context

2018-02-14 Thread Ingo Molnar
Wed, 14 Feb 2018 10:24:41 +0100 Subject: [PATCH] watchdog: hpwdt: Remove spinlock acquire and BIOS calls from NMI context Taking a spinlock and calling into the firmware are problematic things to do from NMI callbacks. It also seems completely pointless in this particular case: -