Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-12 Thread Jiang Liu
On 2015/3/13 0:08, Rafael J. Wysocki wrote: > On Thursday, March 12, 2015 09:41:21 AM Jiang Liu wrote: >> On 2015/3/12 9:17, Rafael J. Wysocki wrote: >>> On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: >> Unfortunately there's a long standing comment in pci_device_remove(): >>

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-12 Thread Rafael J. Wysocki
On Thursday, March 12, 2015 09:41:21 AM Jiang Liu wrote: > On 2015/3/12 9:17, Rafael J. Wysocki wrote: > > On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: > Unfortunately there's a long standing comment in pci_device_remove(): > > /* > * We would

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-12 Thread Rafael J. Wysocki
On Thursday, March 12, 2015 09:41:21 AM Jiang Liu wrote: On 2015/3/12 9:17, Rafael J. Wysocki wrote: On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: Unfortunately there's a long standing comment in pci_device_remove(): /* * We would love to complain here if

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-12 Thread Jiang Liu
On 2015/3/13 0:08, Rafael J. Wysocki wrote: On Thursday, March 12, 2015 09:41:21 AM Jiang Liu wrote: On 2015/3/12 9:17, Rafael J. Wysocki wrote: On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: Unfortunately there's a long standing comment in pci_device_remove(): /*

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Jiang Liu
On 2015/3/12 9:17, Rafael J. Wysocki wrote: > On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: Unfortunately there's a long standing comment in pci_device_remove(): /* * We would love to complain here if pci_dev->is_enabled is set, that

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Rafael J. Wysocki
On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: > >> Unfortunately there's a long standing comment in pci_device_remove(): > >> > >> /* > >> * We would love to complain here if pci_dev->is_enabled is set, > >> that > >> * the driver should have called

RE: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Luck, Tony
>> Unfortunately there's a long standing comment in pci_device_remove(): >> >> /* >> * We would love to complain here if pci_dev->is_enabled is set, that >> * the driver should have called pci_disable_device(), but the >> * unfortunate fact is there are too many

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Rafael J. Wysocki
On Wednesday, March 11, 2015 10:47:30 AM Alex Williamson wrote: > On Thu, 2015-03-05 at 20:51 -0700, Alex Williamson wrote: > > On Fri, 2015-03-06 at 09:49 +0800, Jiang Liu wrote: > > > On 2015/3/6 5:06, Alex Williamson wrote: > > > > The IRQ resource for a device is established when

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Alex Williamson
On Thu, 2015-03-05 at 20:51 -0700, Alex Williamson wrote: > On Fri, 2015-03-06 at 09:49 +0800, Jiang Liu wrote: > > On 2015/3/6 5:06, Alex Williamson wrote: > > > The IRQ resource for a device is established when pci_enabled_device() > > > is called on a fully disabled device (ie. enable_cnt ==

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Alex Williamson
On Thu, 2015-03-05 at 20:51 -0700, Alex Williamson wrote: On Fri, 2015-03-06 at 09:49 +0800, Jiang Liu wrote: On 2015/3/6 5:06, Alex Williamson wrote: The IRQ resource for a device is established when pci_enabled_device() is called on a fully disabled device (ie. enable_cnt == 0). With

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Rafael J. Wysocki
On Wednesday, March 11, 2015 10:47:30 AM Alex Williamson wrote: On Thu, 2015-03-05 at 20:51 -0700, Alex Williamson wrote: On Fri, 2015-03-06 at 09:49 +0800, Jiang Liu wrote: On 2015/3/6 5:06, Alex Williamson wrote: The IRQ resource for a device is established when pci_enabled_device()

RE: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Luck, Tony
Unfortunately there's a long standing comment in pci_device_remove(): /* * We would love to complain here if pci_dev-is_enabled is set, that * the driver should have called pci_disable_device(), but the * unfortunate fact is there are too many odd BIOS and

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Rafael J. Wysocki
On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: Unfortunately there's a long standing comment in pci_device_remove(): /* * We would love to complain here if pci_dev-is_enabled is set, that * the driver should have called pci_disable_device(), but

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-11 Thread Jiang Liu
On 2015/3/12 9:17, Rafael J. Wysocki wrote: On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: Unfortunately there's a long standing comment in pci_device_remove(): /* * We would love to complain here if pci_dev-is_enabled is set, that * the driver should

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-05 Thread Alex Williamson
On Fri, 2015-03-06 at 09:49 +0800, Jiang Liu wrote: > On 2015/3/6 5:06, Alex Williamson wrote: > > The IRQ resource for a device is established when pci_enabled_device() > > is called on a fully disabled device (ie. enable_cnt == 0). With > > commit b4b55cda5874 ("x86/PCI: Refine the way to

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-05 Thread Jiang Liu
On 2015/3/6 5:06, Alex Williamson wrote: > The IRQ resource for a device is established when pci_enabled_device() > is called on a fully disabled device (ie. enable_cnt == 0). With > commit b4b55cda5874 ("x86/PCI: Refine the way to release PCI IRQ > resources") this same IRQ resource is released

[PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-05 Thread Alex Williamson
The IRQ resource for a device is established when pci_enabled_device() is called on a fully disabled device (ie. enable_cnt == 0). With commit b4b55cda5874 ("x86/PCI: Refine the way to release PCI IRQ resources") this same IRQ resource is released when the driver is unbound from the device,

[PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-05 Thread Alex Williamson
The IRQ resource for a device is established when pci_enabled_device() is called on a fully disabled device (ie. enable_cnt == 0). With commit b4b55cda5874 (x86/PCI: Refine the way to release PCI IRQ resources) this same IRQ resource is released when the driver is unbound from the device,

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-05 Thread Jiang Liu
On 2015/3/6 5:06, Alex Williamson wrote: The IRQ resource for a device is established when pci_enabled_device() is called on a fully disabled device (ie. enable_cnt == 0). With commit b4b55cda5874 (x86/PCI: Refine the way to release PCI IRQ resources) this same IRQ resource is released when

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-05 Thread Alex Williamson
On Fri, 2015-03-06 at 09:49 +0800, Jiang Liu wrote: On 2015/3/6 5:06, Alex Williamson wrote: The IRQ resource for a device is established when pci_enabled_device() is called on a fully disabled device (ie. enable_cnt == 0). With commit b4b55cda5874 (x86/PCI: Refine the way to release PCI