Re: [PATCH] x86/platform/UV: Fix support for EFI_OLD_MEMMAP after BIOS callback updates

2016-10-19 Thread Ingo Molnar
* Matt Fleming wrote: > On Tue, 18 Oct, at 07:47:38AM, Alex Thorlton wrote: > > Some time ago, we brought our UV BIOS callback code up to speed with the > > new EFI memory mapping scheme, in commit: > > > > d1be84a232e3 ("x86/uv: Update uv_bios_call() to use > > efi_call_virt_pointer()") >

Re: [PATCH] x86/platform/UV: Fix support for EFI_OLD_MEMMAP after BIOS callback updates

2016-10-19 Thread Matt Fleming
On Tue, 18 Oct, at 07:47:38AM, Alex Thorlton wrote: > Some time ago, we brought our UV BIOS callback code up to speed with the > new EFI memory mapping scheme, in commit: > > d1be84a232e3 ("x86/uv: Update uv_bios_call() to use > efi_call_virt_pointer()") > > By leveraging some changes that I

Re: [PATCH] x86/platform/UV: Fix support for EFI_OLD_MEMMAP after BIOS callback updates

2016-10-19 Thread Alex Thorlton
On Wed, Oct 19, 2016 at 12:32:00PM +0100, Matt Fleming wrote: > Could you please invert the conditional? I had to read it 3 times to > make sure it was correct given the comment that precedes it. E.g. this > is preferable, > > if (efi_enabled(EFI_OLD_MEMMAP)) > ret = efi_call((

[PATCH] x86/platform/UV: Fix support for EFI_OLD_MEMMAP after BIOS callback updates

2016-10-18 Thread Alex Thorlton
Some time ago, we brought our UV BIOS callback code up to speed with the new EFI memory mapping scheme, in commit: d1be84a232e3 ("x86/uv: Update uv_bios_call() to use efi_call_virt_pointer()") By leveraging some changes that I made to a few of the EFI runtime callback mechanisms, in commit: