Re: [PATCH] xen/pvcalls: fix null pointer dereference on map->sock

2018-02-22 Thread Juergen Gross 
On 22/02/18 18:22, Colin King wrote:
> From: Colin Ian King 
> 
> Currently if map is null then a potential null pointer deference
> occurs when calling sock_release on map->sock.  I believe the
> actual intention was to call sock_release on sock instead. Fix
> this.
> 
> Fixes: 5db4d286a8ef ("xen/pvcalls: implement connect command")
> Signed-off-by: Colin Ian King 

Hmm, yes, kind of obvious. :-)

Reviewed-by: Juergen Gross 


Juergen

Re: [PATCH] xen/pvcalls: fix null pointer dereference on map->sock

2018-02-22 Thread Juergen Gross 
On 22/02/18 18:22, Colin King wrote:
> From: Colin Ian King 
> 
> Currently if map is null then a potential null pointer deference
> occurs when calling sock_release on map->sock.  I believe the
> actual intention was to call sock_release on sock instead. Fix
> this.
> 
> Fixes: 5db4d286a8ef ("xen/pvcalls: implement connect command")
> Signed-off-by: Colin Ian King 

Hmm, yes, kind of obvious. :-)

Reviewed-by: Juergen Gross 


Juergen

[PATCH] xen/pvcalls: fix null pointer dereference on map->sock

2018-02-22 Thread Colin King 
From: Colin Ian King 

Currently if map is null then a potential null pointer deference
occurs when calling sock_release on map->sock.  I believe the
actual intention was to call sock_release on sock instead. Fix
this.

Fixes: 5db4d286a8ef ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King 
---
 drivers/xen/pvcalls-back.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 156e5aea36db..b1092fbefa63 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -416,7 +416,7 @@ static int pvcalls_back_connect(struct xenbus_device *dev,
sock);
if (!map) {
ret = -EFAULT;
-   sock_release(map->sock);
+   sock_release(sock);
}
 
 out:
-- 
2.15.1

[PATCH] xen/pvcalls: fix null pointer dereference on map->sock

2018-02-22 Thread Colin King 
From: Colin Ian King 

Currently if map is null then a potential null pointer deference
occurs when calling sock_release on map->sock.  I believe the
actual intention was to call sock_release on sock instead. Fix
this.

Fixes: 5db4d286a8ef ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King 
---
 drivers/xen/pvcalls-back.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 156e5aea36db..b1092fbefa63 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -416,7 +416,7 @@ static int pvcalls_back_connect(struct xenbus_device *dev,
sock);
if (!map) {
ret = -EFAULT;
-   sock_release(map->sock);
+   sock_release(sock);
}
 
 out:
-- 
2.15.1