Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-08-07 Thread Joe Perches
On Tue, 2019-08-06 at 22:15 -0700, Nathan Chancellor wrote: > Just for everyone else (since I commented on our issue tracker), this is > now fixed in Linus's tree as of commit 1f6607250331 ("iwlwifi: dbg_ini: > fix compile time assert build errors"). I think this change is incomplete and suggest

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-08-06 Thread Luciano Coelho
On Tue, 2019-08-06 at 22:15 -0700, Nathan Chancellor wrote: > On Tue, Aug 06, 2019 at 03:37:42PM -0700, Nick Desaulniers wrote: > > On Thu, Aug 1, 2019 at 12:11 AM Johannes Berg > > wrote: > > > > > > > Luca, you said this was already fixed in your internal tree, and the fix > > > > would

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-08-06 Thread Nathan Chancellor
On Tue, Aug 06, 2019 at 03:37:42PM -0700, Nick Desaulniers wrote: > On Thu, Aug 1, 2019 at 12:11 AM Johannes Berg > wrote: > > > > > > > Luca, you said this was already fixed in your internal tree, and the fix > > > would appear soon in next, but I don't see anything in linux-next? > > > > Luca

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-08-06 Thread Nick Desaulniers
On Thu, Aug 1, 2019 at 12:11 AM Johannes Berg wrote: > > > > Luca, you said this was already fixed in your internal tree, and the fix > > would appear soon in next, but I don't see anything in linux-next? > > Luca is still on vacation, but I just sent out a version of the patch we > had applied

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-08-02 Thread Michael Ellerman
Johannes Berg writes: >> Luca, you said this was already fixed in your internal tree, and the fix >> would appear soon in next, but I don't see anything in linux-next? > > Luca is still on vacation, but I just sent out a version of the patch we > had applied internally. Awesome, thanks. cheers

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-08-01 Thread Johannes Berg
> Luca, you said this was already fixed in your internal tree, and the fix > would appear soon in next, but I don't see anything in linux-next? Luca is still on vacation, but I just sent out a version of the patch we had applied internally. Also turns out it wasn't actually _fixed_, just

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-31 Thread Michael Ellerman
Nick Desaulniers writes: > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: > in function `_iwl_fw_dbg_apply_point': > dbg.c:(.text+0x827a): undefined reference to `__compiletime_assert_2387' This breakage is also seen in

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-24 Thread Sedat Dilek
On Tue, Jul 16, 2019 at 11:15 PM Luca Coelho wrote: > > On Tue, 2019-07-16 at 10:28 -0700, Nick Desaulniers wrote: > > On Thu, Jul 11, 2019 at 7:15 PM Joe Perches wrote: > > > On Thu, 2019-07-11 at 17:17 -0700, Nick Desaulniers wrote: > > > > Commit r353569 in prerelease Clang-9 is producing a

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-16 Thread Nick Desaulniers
On Tue, Jul 16, 2019 at 2:15 PM Luca Coelho wrote: > > On Tue, 2019-07-16 at 10:28 -0700, Nick Desaulniers wrote: > > On Thu, Jul 11, 2019 at 7:15 PM Joe Perches wrote: > > > Better still would be to use the format string directly > > > in both locations instead of trying to deduplicate it > > >

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-16 Thread Luca Coelho
On Tue, 2019-07-16 at 10:28 -0700, Nick Desaulniers wrote: > On Thu, Jul 11, 2019 at 7:15 PM Joe Perches wrote: > > On Thu, 2019-07-11 at 17:17 -0700, Nick Desaulniers wrote: > > > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > > > > > ld:

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-16 Thread Nick Desaulniers
On Thu, Jul 11, 2019 at 7:15 PM Joe Perches wrote: > > On Thu, 2019-07-11 at 17:17 -0700, Nick Desaulniers wrote: > > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > > > ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: > > in function `_iwl_fw_dbg_apply_point': > >

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-11 Thread Joe Perches
On Thu, 2019-07-11 at 17:17 -0700, Nick Desaulniers wrote: > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: > in function `_iwl_fw_dbg_apply_point': > dbg.c:(.text+0x827a): undefined reference to

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-11 Thread Nathan Chancellor
On Thu, Jul 11, 2019 at 05:17:06PM -0700, Nick Desaulniers wrote: > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: > in function `_iwl_fw_dbg_apply_point': > dbg.c:(.text+0x827a): undefined reference to

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-11 Thread Nick Desaulniers
On Thu, Jul 11, 2019 at 5:17 PM Nick Desaulniers wrote: > > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: > in function `_iwl_fw_dbg_apply_point': > dbg.c:(.text+0x827a): undefined reference to `__compiletime_assert_2387'

[PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-11 Thread Nick Desaulniers
Commit r353569 in prerelease Clang-9 is producing a linkage failure: ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: in function `_iwl_fw_dbg_apply_point': dbg.c:(.text+0x827a): undefined reference to `__compiletime_assert_2387' when the following configs are enabled: - CONFIG_IWLWIFI -