Re: [PATCH -next] phy: rockchip-typec: fix non static symbol warnings
On Wed, Sep 21, 2016 at 8:35 PM, Wei Yongjunwrote: > From: Wei Yongjun > > Fixes the following sparse warnings: > > drivers/phy/phy-rockchip-typec.c:295:16: warning: > symbol 'usb3_pll_cfg' was not declared. Should it be static? > drivers/phy/phy-rockchip-typec.c:312:16: warning: > symbol 'dp_pll_cfg' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun > --- > drivers/phy/phy-rockchip-typec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-rockchip-typec.c > b/drivers/phy/phy-rockchip-typec.c > index 7cfb0f8..555604c 100644 > --- a/drivers/phy/phy-rockchip-typec.c > +++ b/drivers/phy/phy-rockchip-typec.c > @@ -292,7 +292,7 @@ struct phy_reg { > u32 addr; > }; > > -struct phy_reg usb3_pll_cfg[] = { > +static struct phy_reg usb3_pll_cfg[] = { const as well ? > { 0xf0, CMN_PLL0_VCOCAL_INIT }, > { 0x18, CMN_PLL0_VCOCAL_ITER }, > { 0xd0, CMN_PLL0_INTDIV }, > @@ -309,7 +309,7 @@ struct phy_reg usb3_pll_cfg[] = { > { 0x8, CMN_DIAG_PLL0_LF_PROG }, > }; > > -struct phy_reg dp_pll_cfg[] = { > +static struct phy_reg dp_pll_cfg[] = { const ? [..] Thanks Vivek -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH -next] phy: rockchip-typec: fix non static symbol warnings
On Wed, Sep 21, 2016 at 8:35 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warnings: > > drivers/phy/phy-rockchip-typec.c:295:16: warning: > symbol 'usb3_pll_cfg' was not declared. Should it be static? > drivers/phy/phy-rockchip-typec.c:312:16: warning: > symbol 'dp_pll_cfg' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun > --- > drivers/phy/phy-rockchip-typec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-rockchip-typec.c > b/drivers/phy/phy-rockchip-typec.c > index 7cfb0f8..555604c 100644 > --- a/drivers/phy/phy-rockchip-typec.c > +++ b/drivers/phy/phy-rockchip-typec.c > @@ -292,7 +292,7 @@ struct phy_reg { > u32 addr; > }; > > -struct phy_reg usb3_pll_cfg[] = { > +static struct phy_reg usb3_pll_cfg[] = { const as well ? > { 0xf0, CMN_PLL0_VCOCAL_INIT }, > { 0x18, CMN_PLL0_VCOCAL_ITER }, > { 0xd0, CMN_PLL0_INTDIV }, > @@ -309,7 +309,7 @@ struct phy_reg usb3_pll_cfg[] = { > { 0x8, CMN_DIAG_PLL0_LF_PROG }, > }; > > -struct phy_reg dp_pll_cfg[] = { > +static struct phy_reg dp_pll_cfg[] = { const ? [..] Thanks Vivek -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[PATCH -next] phy: rockchip-typec: fix non static symbol warnings
From: Wei YongjunFixes the following sparse warnings: drivers/phy/phy-rockchip-typec.c:295:16: warning: symbol 'usb3_pll_cfg' was not declared. Should it be static? drivers/phy/phy-rockchip-typec.c:312:16: warning: symbol 'dp_pll_cfg' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/phy/phy-rockchip-typec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-rockchip-typec.c b/drivers/phy/phy-rockchip-typec.c index 7cfb0f8..555604c 100644 --- a/drivers/phy/phy-rockchip-typec.c +++ b/drivers/phy/phy-rockchip-typec.c @@ -292,7 +292,7 @@ struct phy_reg { u32 addr; }; -struct phy_reg usb3_pll_cfg[] = { +static struct phy_reg usb3_pll_cfg[] = { { 0xf0, CMN_PLL0_VCOCAL_INIT }, { 0x18, CMN_PLL0_VCOCAL_ITER }, { 0xd0, CMN_PLL0_INTDIV }, @@ -309,7 +309,7 @@ struct phy_reg usb3_pll_cfg[] = { { 0x8, CMN_DIAG_PLL0_LF_PROG }, }; -struct phy_reg dp_pll_cfg[] = { +static struct phy_reg dp_pll_cfg[] = { { 0xf0, CMN_PLL1_VCOCAL_INIT }, { 0x18, CMN_PLL1_VCOCAL_ITER }, { 0x30b9, CMN_PLL1_VCOCAL_START },
[PATCH -next] phy: rockchip-typec: fix non static symbol warnings
From: Wei Yongjun Fixes the following sparse warnings: drivers/phy/phy-rockchip-typec.c:295:16: warning: symbol 'usb3_pll_cfg' was not declared. Should it be static? drivers/phy/phy-rockchip-typec.c:312:16: warning: symbol 'dp_pll_cfg' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/phy/phy-rockchip-typec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-rockchip-typec.c b/drivers/phy/phy-rockchip-typec.c index 7cfb0f8..555604c 100644 --- a/drivers/phy/phy-rockchip-typec.c +++ b/drivers/phy/phy-rockchip-typec.c @@ -292,7 +292,7 @@ struct phy_reg { u32 addr; }; -struct phy_reg usb3_pll_cfg[] = { +static struct phy_reg usb3_pll_cfg[] = { { 0xf0, CMN_PLL0_VCOCAL_INIT }, { 0x18, CMN_PLL0_VCOCAL_ITER }, { 0xd0, CMN_PLL0_INTDIV }, @@ -309,7 +309,7 @@ struct phy_reg usb3_pll_cfg[] = { { 0x8, CMN_DIAG_PLL0_LF_PROG }, }; -struct phy_reg dp_pll_cfg[] = { +static struct phy_reg dp_pll_cfg[] = { { 0xf0, CMN_PLL1_VCOCAL_INIT }, { 0x18, CMN_PLL1_VCOCAL_ITER }, { 0x30b9, CMN_PLL1_VCOCAL_START },