Re: [PATCH -next] pinctrl: qcom: spmi-mpp: Fix err handling of pmic_mpp_set_mux

2018-09-21 Thread Linus Walleij 
On Wed, Sep 19, 2018 at 6:48 PM YueHaibing  wrote:

> 'ret' should be returned while pmic_mpp_write_mode_ctl fails.
>
> Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement support for sink 
> mode")
> Signed-off-by: YueHaibing 

Patch applied.

Yours,
Linus Walleij

Re: [PATCH -next] pinctrl: qcom: spmi-mpp: Fix err handling of pmic_mpp_set_mux

2018-09-21 Thread Linus Walleij 
On Wed, Sep 19, 2018 at 6:48 PM YueHaibing  wrote:

> 'ret' should be returned while pmic_mpp_write_mode_ctl fails.
>
> Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement support for sink 
> mode")
> Signed-off-by: YueHaibing 

Patch applied.

Yours,
Linus Walleij

[PATCH -next] pinctrl: qcom: spmi-mpp: Fix err handling of pmic_mpp_set_mux

2018-09-19 Thread YueHaibing 
'ret' should be returned while pmic_mpp_write_mode_ctl fails. 

Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement support for sink mode")
Signed-off-by: YueHaibing 
---
 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c 
b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
index 98f6f40..d6ddc47 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
@@ -319,6 +319,8 @@ static int pmic_mpp_set_mux(struct pinctrl_dev *pctldev, 
unsigned function,
pad->function = function;
 
ret = pmic_mpp_write_mode_ctl(state, pad);
+   if (ret < 0)
+   return ret;
 
val = pad->is_enabled << PMIC_MPP_REG_MASTER_EN_SHIFT;

[PATCH -next] pinctrl: qcom: spmi-mpp: Fix err handling of pmic_mpp_set_mux

2018-09-19 Thread YueHaibing 
'ret' should be returned while pmic_mpp_write_mode_ctl fails. 

Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement support for sink mode")
Signed-off-by: YueHaibing 
---
 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c 
b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
index 98f6f40..d6ddc47 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
@@ -319,6 +319,8 @@ static int pmic_mpp_set_mux(struct pinctrl_dev *pctldev, 
unsigned function,
pad->function = function;
 
ret = pmic_mpp_write_mode_ctl(state, pad);
+   if (ret < 0)
+   return ret;
 
val = pad->is_enabled << PMIC_MPP_REG_MASTER_EN_SHIFT;