Re: [PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

[Al Viro]

On Sat, Nov 10, 2018 at 04:13:24AM +, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> fs/sysv/inode.c: In function '__sysv_write_inode':
> fs/sysv/inode.c:239:6: warning:
>  variable 'err' set but not used [-Wunused-but-set-variable]
> 
> __sysv_write_inode should return 'err' instead of 0
> 
> Fixes: 05459ca81ac3 ("repair sysv_write_inode(), switch sysv to 
> simple_fsync()")
> Signed-off-by: YueHaibing 

Applied.

Re: [PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

[Al Viro]

On Sat, Nov 10, 2018 at 04:13:24AM +, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> fs/sysv/inode.c: In function '__sysv_write_inode':
> fs/sysv/inode.c:239:6: warning:
>  variable 'err' set but not used [-Wunused-but-set-variable]
> 
> __sysv_write_inode should return 'err' instead of 0
> 
> Fixes: 05459ca81ac3 ("repair sysv_write_inode(), switch sysv to 
> simple_fsync()")
> Signed-off-by: YueHaibing 

Applied.

Re: [PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

[Christoph Hellwig]

Looks fine:

Reviewed-by: Christoph Hellwig 

Al, can you queue it up?

Re: [PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

[Christoph Hellwig]

Looks fine:

Reviewed-by: Christoph Hellwig 

Al, can you queue it up?

[PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

[YueHaibing]

Fixes gcc '-Wunused-but-set-variable' warning:

fs/sysv/inode.c: In function '__sysv_write_inode':
fs/sysv/inode.c:239:6: warning:
 variable 'err' set but not used [-Wunused-but-set-variable]

__sysv_write_inode should return 'err' instead of 0

Fixes: 05459ca81ac3 ("repair sysv_write_inode(), switch sysv to simple_fsync()")
Signed-off-by: YueHaibing 
---
 fs/sysv/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c
index 499a20a..273736f 100644
--- a/fs/sysv/inode.c
+++ b/fs/sysv/inode.c
@@ -275,7 +275,7 @@ static int __sysv_write_inode(struct inode *inode, int wait)
 }
 }
brelse(bh);
-   return 0;
+   return err;
 }
 
 int sysv_write_inode(struct inode *inode, struct writeback_control *wbc)

[PATCH -next] sysv: return 'err' instead of 0 in __sysv_write_inode

[YueHaibing]

Fixes gcc '-Wunused-but-set-variable' warning:

fs/sysv/inode.c: In function '__sysv_write_inode':
fs/sysv/inode.c:239:6: warning:
 variable 'err' set but not used [-Wunused-but-set-variable]

__sysv_write_inode should return 'err' instead of 0

Fixes: 05459ca81ac3 ("repair sysv_write_inode(), switch sysv to simple_fsync()")
Signed-off-by: YueHaibing 
---
 fs/sysv/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c
index 499a20a..273736f 100644
--- a/fs/sysv/inode.c
+++ b/fs/sysv/inode.c
@@ -275,7 +275,7 @@ static int __sysv_write_inode(struct inode *inode, int wait)
 }
 }
brelse(bh);
-   return 0;
+   return err;
 }
 
 int sysv_write_inode(struct inode *inode, struct writeback_control *wbc)