Re: [PATCH 0/3] Fix y2038 issues for security/keys subsystem
Hi James, On 21 August 2017 at 20:12, Baolin Wang wrote: > Hi David and James, > > On 9 August 2017 at 16:28, David Howells wrote: >> The rxrpc patch isn't part of the security/keys subsystem. I'll push it >> to the network tree. The other two I'll push to James. > > Could you apply this patch serials if there are no other comments? Thanks. Could you apply patch1 and patch2? I have seen patch3 was merged into 4.14 by David. Thanks. -- Baolin.wang Best Regards
Re: [PATCH 0/3] Fix y2038 issues for security/keys subsystem
Hi David and James, On 9 August 2017 at 16:28, David Howells wrote: > The rxrpc patch isn't part of the security/keys subsystem. I'll push it > to the network tree. The other two I'll push to James. Could you apply this patch serials if there are no other comments? Thanks. -- Baolin.wang Best Regards
Re: [PATCH 0/3] Fix y2038 issues for security/keys subsystem
Hi Arnd, On 9 August 2017 at 16:44, Arnd Bergmann wrote: > On Wed, Aug 9, 2017 at 4:51 AM, Baolin Wang wrote: >> Since 'time_t', 'timeval' and 'timespec' types are not year 2038 safe on >> 32 bits system, this patchset tries to fix this issues for security/keys >> subsystem and net/rxrpc subsystem which is connected with security/keys >> subsystem. >> >> Baolin Wang (3): >> security: keys: Replace time_t/timespec with time64_t >> security: keys: Replace time_t with time64_t for struct >> key_preparsed_payload >> net: rxrpc: Replace time_t type with time64_t type > > Hi David, > > I did a private review before Baolin posted these patches, this version look > correct to me, though I would like to see some clarification from you for the > rxrpc portion, I'll reply there separately. > > All three patches > > Reviewed-by: Arnd Bergmann Thanks for your reviewed tag. -- Baolin.wang Best Regards
Re: [PATCH 0/3] Fix y2038 issues for security/keys subsystem
On 9 August 2017 at 16:28, David Howells wrote: > The rxrpc patch isn't part of the security/keys subsystem. I'll push it > to the network tree. The other two I'll push to James. Thanks David. -- Baolin.wang Best Regards
Re: [PATCH 0/3] Fix y2038 issues for security/keys subsystem
On Wed, Aug 9, 2017 at 4:51 AM, Baolin Wang wrote: > Since 'time_t', 'timeval' and 'timespec' types are not year 2038 safe on > 32 bits system, this patchset tries to fix this issues for security/keys > subsystem and net/rxrpc subsystem which is connected with security/keys > subsystem. > > Baolin Wang (3): > security: keys: Replace time_t/timespec with time64_t > security: keys: Replace time_t with time64_t for struct > key_preparsed_payload > net: rxrpc: Replace time_t type with time64_t type Hi David, I did a private review before Baolin posted these patches, this version look correct to me, though I would like to see some clarification from you for the rxrpc portion, I'll reply there separately. All three patches Reviewed-by: Arnd Bergmann
Re: [PATCH 0/3] Fix y2038 issues for security/keys subsystem
The rxrpc patch isn't part of the security/keys subsystem. I'll push it to the network tree. The other two I'll push to James. David
[PATCH 0/3] Fix y2038 issues for security/keys subsystem
Since 'time_t', 'timeval' and 'timespec' types are not year 2038 safe on 32 bits system, this patchset tries to fix this issues for security/keys subsystem and net/rxrpc subsystem which is connected with security/keys subsystem. Baolin Wang (3): security: keys: Replace time_t/timespec with time64_t security: keys: Replace time_t with time64_t for struct key_preparsed_payload net: rxrpc: Replace time_t type with time64_t type include/keys/rxrpc-type.h| 21 + include/linux/key-type.h |2 +- include/linux/key.h |7 --- net/rxrpc/ar-internal.h |2 +- net/rxrpc/key.c | 22 ++ net/rxrpc/rxkad.c| 14 +++--- security/keys/gc.c | 20 ++-- security/keys/internal.h |8 security/keys/key.c | 27 ++- security/keys/keyring.c | 18 +- security/keys/permission.c |3 +-- security/keys/proc.c | 20 ++-- security/keys/process_keys.c |2 +- 13 files changed, 93 insertions(+), 73 deletions(-) -- 1.7.9.5