Re: [PATCH 0/4] DT platform device name collision fixes
On 5/7/2014 3:52 PM, Frank Rowand wrote: > On 5/7/2014 2:48 PM, Rob Herring wrote: >> From: Rob Herring >> >> This series fixes the device naming collisions that can occur with >> nultiple devices having the same name and non-translatable unit >> addresses. This issue was raised in this thread[1]. I intend to merge >> this regardless of whether or not some hierarchy in sysfs is created. >> That is really a separate issue independent of these fixes. >> >> I found and fix a couple of other issues in the process of testing the >> fix. >> >> Rob >> >> [1] https://lkml.org/lkml/2014/4/23/312 >> >> Rob Herring (4): >> of/selftest: add testcase for nodes with same name and address >> of/platform: return error on of_platform_device_create_pdata failure >> of/platform: fix device naming for non-translatable addresses >> of: kill off of_can_translate_address > > My opinion is that this approach is not a good approach to solving the > problem. It is papering over a symptom, instead of dealing with the > root cause. > > But despite my opinion, you can add to patches 2-4 (I did not test > the self-test added in patch 1): > >Tested-by: frowand.l...@gmail.com > > The patches resolve the name conflict originally reported for the > qcomm PMIC, tested on 3.15-rc1, with a bunch of out of tree > patches. And you can add to the 4 patches: Reviewed-by: Frank Rowand -Frank -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] DT platform device name collision fixes
On 5/7/2014 2:48 PM, Rob Herring wrote: > From: Rob Herring > > This series fixes the device naming collisions that can occur with > nultiple devices having the same name and non-translatable unit > addresses. This issue was raised in this thread[1]. I intend to merge > this regardless of whether or not some hierarchy in sysfs is created. > That is really a separate issue independent of these fixes. > > I found and fix a couple of other issues in the process of testing the > fix. > > Rob > > [1] https://lkml.org/lkml/2014/4/23/312 > > Rob Herring (4): > of/selftest: add testcase for nodes with same name and address > of/platform: return error on of_platform_device_create_pdata failure > of/platform: fix device naming for non-translatable addresses > of: kill off of_can_translate_address My opinion is that this approach is not a good approach to solving the problem. It is papering over a symptom, instead of dealing with the root cause. But despite my opinion, you can add to patches 2-4 (I did not test the self-test added in patch 1): Tested-by: Frank Rowand The patches resolve the name conflict originally reported for the qcomm PMIC, tested on 3.15-rc1, with a bunch of out of tree patches. -Frank -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/4] DT platform device name collision fixes
From: Rob Herring This series fixes the device naming collisions that can occur with nultiple devices having the same name and non-translatable unit addresses. This issue was raised in this thread[1]. I intend to merge this regardless of whether or not some hierarchy in sysfs is created. That is really a separate issue independent of these fixes. I found and fix a couple of other issues in the process of testing the fix. Rob [1] https://lkml.org/lkml/2014/4/23/312 Rob Herring (4): of/selftest: add testcase for nodes with same name and address of/platform: return error on of_platform_device_create_pdata failure of/platform: fix device naming for non-translatable addresses of: kill off of_can_translate_address drivers/of/address.c | 22 + drivers/of/platform.c| 20 +--- drivers/of/selftest.c| 23 ++ drivers/of/testcase-data/testcases.dtsi | 1 + drivers/of/testcase-data/tests-platform.dtsi | 35 include/linux/of_address.h | 1 - 6 files changed, 66 insertions(+), 36 deletions(-) create mode 100644 drivers/of/testcase-data/tests-platform.dtsi -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/4] DT platform device name collision fixes
From: Rob Herring r...@kernel.org This series fixes the device naming collisions that can occur with nultiple devices having the same name and non-translatable unit addresses. This issue was raised in this thread[1]. I intend to merge this regardless of whether or not some hierarchy in sysfs is created. That is really a separate issue independent of these fixes. I found and fix a couple of other issues in the process of testing the fix. Rob [1] https://lkml.org/lkml/2014/4/23/312 Rob Herring (4): of/selftest: add testcase for nodes with same name and address of/platform: return error on of_platform_device_create_pdata failure of/platform: fix device naming for non-translatable addresses of: kill off of_can_translate_address drivers/of/address.c | 22 + drivers/of/platform.c| 20 +--- drivers/of/selftest.c| 23 ++ drivers/of/testcase-data/testcases.dtsi | 1 + drivers/of/testcase-data/tests-platform.dtsi | 35 include/linux/of_address.h | 1 - 6 files changed, 66 insertions(+), 36 deletions(-) create mode 100644 drivers/of/testcase-data/tests-platform.dtsi -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] DT platform device name collision fixes
On 5/7/2014 2:48 PM, Rob Herring wrote: From: Rob Herring r...@kernel.org This series fixes the device naming collisions that can occur with nultiple devices having the same name and non-translatable unit addresses. This issue was raised in this thread[1]. I intend to merge this regardless of whether or not some hierarchy in sysfs is created. That is really a separate issue independent of these fixes. I found and fix a couple of other issues in the process of testing the fix. Rob [1] https://lkml.org/lkml/2014/4/23/312 Rob Herring (4): of/selftest: add testcase for nodes with same name and address of/platform: return error on of_platform_device_create_pdata failure of/platform: fix device naming for non-translatable addresses of: kill off of_can_translate_address My opinion is that this approach is not a good approach to solving the problem. It is papering over a symptom, instead of dealing with the root cause. But despite my opinion, you can add to patches 2-4 (I did not test the self-test added in patch 1): Tested-by: Frank Rowand frank.row...@sonymobile.com The patches resolve the name conflict originally reported for the qcomm PMIC, tested on 3.15-rc1, with a bunch of out of tree patches. -Frank -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] DT platform device name collision fixes
On 5/7/2014 3:52 PM, Frank Rowand wrote: On 5/7/2014 2:48 PM, Rob Herring wrote: From: Rob Herring r...@kernel.org This series fixes the device naming collisions that can occur with nultiple devices having the same name and non-translatable unit addresses. This issue was raised in this thread[1]. I intend to merge this regardless of whether or not some hierarchy in sysfs is created. That is really a separate issue independent of these fixes. I found and fix a couple of other issues in the process of testing the fix. Rob [1] https://lkml.org/lkml/2014/4/23/312 Rob Herring (4): of/selftest: add testcase for nodes with same name and address of/platform: return error on of_platform_device_create_pdata failure of/platform: fix device naming for non-translatable addresses of: kill off of_can_translate_address My opinion is that this approach is not a good approach to solving the problem. It is papering over a symptom, instead of dealing with the root cause. But despite my opinion, you can add to patches 2-4 (I did not test the self-test added in patch 1): Tested-by: frowand.l...@gmail.com frank.row...@sonymobile.com The patches resolve the name conflict originally reported for the qcomm PMIC, tested on 3.15-rc1, with a bunch of out of tree patches. And you can add to the 4 patches: Reviewed-by: Frank Rowand frank.row...@sonymobile.com -Frank -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
