Re: [PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts.

2016-05-17 Thread Marc Zyngier 
On 17/05/16 06:05, Purna Chandra Mandal wrote:
> From: Joshua Henderson 
> 
> The wrong external interrupt bits are being set, offset by 1.
> 
> Signed-off-by: Joshua Henderson 
> Signed-off-by: Purna Chandra Mandal 

Acked-by: Marc Zyngier 

I'll queue that for post -rc1.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts.

2016-05-17 Thread Marc Zyngier 
On 17/05/16 06:05, Purna Chandra Mandal wrote:
> From: Joshua Henderson 
> 
> The wrong external interrupt bits are being set, offset by 1.
> 
> Signed-off-by: Joshua Henderson 
> Signed-off-by: Purna Chandra Mandal 

Acked-by: Marc Zyngier 

I'll queue that for post -rc1.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny...

[PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts.

2016-05-16 Thread Purna Chandra Mandal 
From: Joshua Henderson 

The wrong external interrupt bits are being set, offset by 1.

Signed-off-by: Joshua Henderson 
Signed-off-by: Purna Chandra Mandal 

---

 drivers/irqchip/irq-pic32-evic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-pic32-evic.c b/drivers/irqchip/irq-pic32-evic.c
index e7155db..73addb4 100644
--- a/drivers/irqchip/irq-pic32-evic.c
+++ b/drivers/irqchip/irq-pic32-evic.c
@@ -91,7 +91,7 @@ static int pic32_set_type_edge(struct irq_data *data,
/* set polarity for external interrupts only */
for (i = 0; i < ARRAY_SIZE(priv->ext_irqs); i++) {
if (priv->ext_irqs[i] == data->hwirq) {
-   ret = pic32_set_ext_polarity(i + 1, flow_type);
+   ret = pic32_set_ext_polarity(i, flow_type);
if (ret)
return ret;
}
-- 
1.8.3.1

[PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts.

2016-05-16 Thread Purna Chandra Mandal 
From: Joshua Henderson 

The wrong external interrupt bits are being set, offset by 1.

Signed-off-by: Joshua Henderson 
Signed-off-by: Purna Chandra Mandal 

---

 drivers/irqchip/irq-pic32-evic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-pic32-evic.c b/drivers/irqchip/irq-pic32-evic.c
index e7155db..73addb4 100644
--- a/drivers/irqchip/irq-pic32-evic.c
+++ b/drivers/irqchip/irq-pic32-evic.c
@@ -91,7 +91,7 @@ static int pic32_set_type_edge(struct irq_data *data,
/* set polarity for external interrupts only */
for (i = 0; i < ARRAY_SIZE(priv->ext_irqs); i++) {
if (priv->ext_irqs[i] == data->hwirq) {
-   ret = pic32_set_ext_polarity(i + 1, flow_type);
+   ret = pic32_set_ext_polarity(i, flow_type);
if (ret)
return ret;
}
-- 
1.8.3.1