Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support

On Tue, Feb 13, 2018 at 10:45:51AM +0100, Jacopo Mondi wrote: > Add initial PFC support for R-Car M3-N (r8a77965) SoC. > No groups or functions defined, just pin and registers enumeration. > > Signed-off-by: Jacopo Mondi > --- > .../bindings/pinctrl/renesas,pfc-pinctrl.txt |1 + Review

Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support

Hi Jacopo, On Wed, Feb 14, 2018 at 2:53 PM, jacopo mondi wrote: > On Wed, Feb 14, 2018 at 02:37:08PM +0100, Geert Uytterhoeven wrote: >> On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi >> wrote: >> > Add initial PFC support for R-Car M3-N (r8a77965) SoC. >> > No groups or functions defined, just

Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support

Hi Geert, thanks for review On Wed, Feb 14, 2018 at 02:37:08PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi > wrote: > > Add initial PFC support for R-Car M3-N (r8a77965) SoC. > > No groups or functions defined, just pin and registers enumera

Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support

Hi Jacopo, On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add initial PFC support for R-Car M3-N (r8a77965) SoC. > No groups or functions defined, just pin and registers enumeration. > > Signed-off-by: Jacopo Mondi Thanks for your patch! Looks mostly OK to me. You do want to compare w

[PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support

Add initial PFC support for R-Car M3-N (r8a77965) SoC. No groups or functions defined, just pin and registers enumeration. Signed-off-by: Jacopo Mondi --- .../bindings/pinctrl/renesas,pfc-pinctrl.txt |1 + drivers/pinctrl/sh-pfc/Kconfig |5 + drivers/pinctrl/sh-