Re: [PATCH 05/19] perf tools: Add refcnt into struct mem_info

On Wed, Mar 07, 2018 at 03:56:59PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 07, 2018 at 04:50:06PM +0100, Jiri Olsa escreveu: > > It's passed along several hists entries in --hierarchy mode, > > so it's better we keep track of it. > > I like this, but you called it... > > > + > > +st

Re: [PATCH 05/19] perf tools: Add refcnt into struct mem_info

Em Wed, Mar 07, 2018 at 04:50:06PM +0100, Jiri Olsa escreveu: > It's passed along several hists entries in --hierarchy mode, > so it's better we keep track of it. I like this, but you called it... > + > +struct mem_info *mem_info__aloc(void) > +{ > + struct mem_info *mi = zalloc(sizeof(*mi))

[PATCH 05/19] perf tools: Add refcnt into struct mem_info

It's passed along several hists entries in --hierarchy mode, so it's better we keep track of it. The current fail I see is that it gets removed in hierarchy --mem-mode mode, where it's shared in the different hierarchies, but removed from the template hist entry, so the report crashes. Link: http