[PATCH 06/57] perf tools: Make several sorting functions global

[Jiri Olsa]

Will be used from external places in following patches.

Link: http://lkml.kernel.org/n/tip-4jyvw21cac7yuqsdkzdo5...@git.kernel.org
Signed-off-by: Jiri Olsa 
---
 tools/perf/util/sort.c | 6 +++---
 tools/perf/util/sort.h | 6 ++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 9f7c1ea9e3ad..452e15a10dd2 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -867,7 +867,7 @@ struct sort_entry sort_cycles = {
 };
 
 /* --sort daddr_sym */
-static int64_t
+int64_t
 sort__daddr_cmp(struct hist_entry *left, struct hist_entry *right)
 {
uint64_t l = 0, r = 0;
@@ -896,7 +896,7 @@ static int hist_entry__daddr_snprintf(struct hist_entry 
*he, char *bf,
 width);
 }
 
-static int64_t
+int64_t
 sort__iaddr_cmp(struct hist_entry *left, struct hist_entry *right)
 {
uint64_t l = 0, r = 0;
@@ -1062,7 +1062,7 @@ static int hist_entry__snoop_snprintf(struct hist_entry 
*he, char *bf,
return repsep_snprintf(bf, size, "%-*s", width, out);
 }
 
-static int64_t
+int64_t
 sort__dcacheline_cmp(struct hist_entry *left, struct hist_entry *right)
 {
u64 l, r;
diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index e93b0fa43704..099c97557d33 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -274,4 +274,10 @@ int sort_dimension__add(struct perf_hpp_list *list, const 
char *tok,
struct perf_evlist *evlist,
int level);
 int output_field_add(struct perf_hpp_list *list, char *tok);
+int64_t
+sort__iaddr_cmp(struct hist_entry *left, struct hist_entry *right);
+int64_t
+sort__daddr_cmp(struct hist_entry *left, struct hist_entry *right);
+int64_t
+sort__dcacheline_cmp(struct hist_entry *left, struct hist_entry *right);
 #endif /* __PERF_SORT_H */
-- 
2.7.4

[PATCH 06/57] perf tools: Make several sorting functions global

[Jiri Olsa]

Will be used from external places in following patches.

Link: http://lkml.kernel.org/n/tip-4jyvw21cac7yuqsdkzdo5...@git.kernel.org
Signed-off-by: Jiri Olsa 
---
 tools/perf/util/sort.c | 6 +++---
 tools/perf/util/sort.h | 6 ++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 9f7c1ea9e3ad..452e15a10dd2 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -867,7 +867,7 @@ struct sort_entry sort_cycles = {
 };
 
 /* --sort daddr_sym */
-static int64_t
+int64_t
 sort__daddr_cmp(struct hist_entry *left, struct hist_entry *right)
 {
uint64_t l = 0, r = 0;
@@ -896,7 +896,7 @@ static int hist_entry__daddr_snprintf(struct hist_entry 
*he, char *bf,
 width);
 }
 
-static int64_t
+int64_t
 sort__iaddr_cmp(struct hist_entry *left, struct hist_entry *right)
 {
uint64_t l = 0, r = 0;
@@ -1062,7 +1062,7 @@ static int hist_entry__snoop_snprintf(struct hist_entry 
*he, char *bf,
return repsep_snprintf(bf, size, "%-*s", width, out);
 }
 
-static int64_t
+int64_t
 sort__dcacheline_cmp(struct hist_entry *left, struct hist_entry *right)
 {
u64 l, r;
diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index e93b0fa43704..099c97557d33 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -274,4 +274,10 @@ int sort_dimension__add(struct perf_hpp_list *list, const 
char *tok,
struct perf_evlist *evlist,
int level);
 int output_field_add(struct perf_hpp_list *list, char *tok);
+int64_t
+sort__iaddr_cmp(struct hist_entry *left, struct hist_entry *right);
+int64_t
+sort__daddr_cmp(struct hist_entry *left, struct hist_entry *right);
+int64_t
+sort__dcacheline_cmp(struct hist_entry *left, struct hist_entry *right);
 #endif /* __PERF_SORT_H */
-- 
2.7.4

Re: [PATCH 06/57] perf tools: Make several sorting functions global

[Arnaldo Carvalho de Melo]

Em Thu, Sep 22, 2016 at 05:36:34PM +0200, Jiri Olsa escreveu:
> Will be used from external places in following patches.
> 
> Link: http://lkml.kernel.org/n/tip-4jyvw21cac7yuqsdkzdo5...@git.kernel.org
> Signed-off-by: Jiri Olsa 

Thanks, applied,

- Arnaldo

Re: [PATCH 06/57] perf tools: Make several sorting functions global

[Arnaldo Carvalho de Melo]

Em Thu, Sep 22, 2016 at 05:36:34PM +0200, Jiri Olsa escreveu:
> Will be used from external places in following patches.
> 
> Link: http://lkml.kernel.org/n/tip-4jyvw21cac7yuqsdkzdo5...@git.kernel.org
> Signed-off-by: Jiri Olsa 

Thanks, applied,

- Arnaldo