[PATCH 060/124] staging: lustre: mdc: fix comparison between signed and unsigned

[James Simmons]

From: Dmitry Eremin 

Change type of client_obd->*_mds_*size from int to __u32 and
argumanets of related create/rename/setattr functions.
Change type of op_data->op_namelen to size_t.
Change type of argument size for all mdc_*_pack() to size_t.

Signed-off-by: Dmitry Eremin 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5577
Reviewed-on: http://review.whamcloud.com/11379
Reviewed-by: John L. Hammond 
Reviewed-by: Fan Yong 
Reviewed-by: Oleg Drokin 
Signed-off-by: James Simmons 
---
 drivers/staging/lustre/lustre/include/obd.h|   23 +++---
 drivers/staging/lustre/lustre/include/obd_class.h  |   12 
 .../staging/lustre/lustre/llite/llite_internal.h   |4 +-
 drivers/staging/lustre/lustre/llite/llite_lib.c|4 +-
 drivers/staging/lustre/lustre/lmv/lmv_intent.c |5 ++-
 drivers/staging/lustre/lustre/lmv/lmv_obd.c|   29 +-
 drivers/staging/lustre/lustre/mdc/mdc_internal.h   |   30 ++-
 drivers/staging/lustre/lustre/mdc/mdc_lib.c|   27 +
 drivers/staging/lustre/lustre/mdc/mdc_locks.c  |   19 ++--
 drivers/staging/lustre/lustre/mdc/mdc_reint.c  |   10 +++---
 drivers/staging/lustre/lustre/mdc/mdc_request.c|   31 ++-
 11 files changed, 101 insertions(+), 93 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/obd.h 
b/drivers/staging/lustre/lustre/include/obd.h
index 6758bf4..8a7c803 100644
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -220,10 +220,10 @@ struct client_obd {
/* max_mds_easize is purely a performance thing so we don't have to
 * call obd_size_diskmd() all the time.
 */
-   int  cl_default_mds_easize;
-   int  cl_max_mds_easize;
-   int  cl_default_mds_cookiesize;
-   int  cl_max_mds_cookiesize;
+   u32  cl_default_mds_easize;
+   u32  cl_max_mds_easize;
+   u32  cl_default_mds_cookiesize;
+   u32  cl_max_mds_cookiesize;
 
enum lustre_sec_part cl_sp_me;
enum lustre_sec_part cl_sp_to;
@@ -745,7 +745,7 @@ struct md_op_data {
struct lustre_handleop_handle;
s64 op_mod_time;
const char   *op_name;
-   int  op_namelen;
+   size_t  op_namelen;
__u32  op_mode;
struct lmv_stripe_md   *op_mea1;
struct lmv_stripe_md   *op_mea2;
@@ -976,8 +976,8 @@ struct md_ops {
int (*close)(struct obd_export *, struct md_op_data *,
 struct md_open_data *, struct ptlrpc_request **);
int (*create)(struct obd_export *, struct md_op_data *,
- const void *, int, int, __u32, __u32, cfs_cap_t,
- __u64, struct ptlrpc_request **);
+ const void *, size_t, umode_t, uid_t, gid_t,
+ cfs_cap_t, __u64, struct ptlrpc_request **);
int (*done_writing)(struct obd_export *, struct md_op_data  *,
struct md_open_data *);
int (*enqueue)(struct obd_export *, struct ldlm_enqueue_info *,
@@ -995,10 +995,10 @@ struct md_ops {
int (*link)(struct obd_export *, struct md_op_data *,
struct ptlrpc_request **);
int (*rename)(struct obd_export *, struct md_op_data *,
- const char *, int, const char *, int,
+ const char *, size_t, const char *, size_t,
  struct ptlrpc_request **);
int (*setattr)(struct obd_export *, struct md_op_data *, void *,
-  int, void *, int, struct ptlrpc_request **,
+  size_t, void *, size_t, struct ptlrpc_request **,
 struct md_open_data **mod);
int (*sync)(struct obd_export *, const struct lu_fid *,
struct ptlrpc_request **);
@@ -1016,7 +1016,7 @@ struct md_ops {
u64, const char *, const char *, int, int, int,
struct ptlrpc_request **);
 
-   int (*init_ea_size)(struct obd_export *, int, int, int, int);
+   int (*init_ea_size)(struct obd_export *, u32, u32, u32, u32);
 
int (*get_lustre_md)(struct obd_export *, struct ptlrpc_request *,
 struct obd_export *, struct obd_export *,
@@ -1139,7 +1139,8 @@ static inline const char *lu_dev_name(const struct 
lu_device *lu_dev)
return lu_dev->ld_obd->obd_name;
 }
 
-static inline bool filename_is_volatile(const char *name, int namelen, int 
*idx)
+static inline bool filename_is_volatile(const char *name, size_t namelen,
+  

[PATCH 060/124] staging: lustre: mdc: fix comparison between signed and unsigned

[James Simmons]

From: Dmitry Eremin 

Change type of client_obd->*_mds_*size from int to __u32 and
argumanets of related create/rename/setattr functions.
Change type of op_data->op_namelen to size_t.
Change type of argument size for all mdc_*_pack() to size_t.

Signed-off-by: Dmitry Eremin 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5577
Reviewed-on: http://review.whamcloud.com/11379
Reviewed-by: John L. Hammond 
Reviewed-by: Fan Yong 
Reviewed-by: Oleg Drokin 
Signed-off-by: James Simmons 
---
 drivers/staging/lustre/lustre/include/obd.h|   23 +++---
 drivers/staging/lustre/lustre/include/obd_class.h  |   12 
 .../staging/lustre/lustre/llite/llite_internal.h   |4 +-
 drivers/staging/lustre/lustre/llite/llite_lib.c|4 +-
 drivers/staging/lustre/lustre/lmv/lmv_intent.c |5 ++-
 drivers/staging/lustre/lustre/lmv/lmv_obd.c|   29 +-
 drivers/staging/lustre/lustre/mdc/mdc_internal.h   |   30 ++-
 drivers/staging/lustre/lustre/mdc/mdc_lib.c|   27 +
 drivers/staging/lustre/lustre/mdc/mdc_locks.c  |   19 ++--
 drivers/staging/lustre/lustre/mdc/mdc_reint.c  |   10 +++---
 drivers/staging/lustre/lustre/mdc/mdc_request.c|   31 ++-
 11 files changed, 101 insertions(+), 93 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/obd.h 
b/drivers/staging/lustre/lustre/include/obd.h
index 6758bf4..8a7c803 100644
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -220,10 +220,10 @@ struct client_obd {
/* max_mds_easize is purely a performance thing so we don't have to
 * call obd_size_diskmd() all the time.
 */
-   int  cl_default_mds_easize;
-   int  cl_max_mds_easize;
-   int  cl_default_mds_cookiesize;
-   int  cl_max_mds_cookiesize;
+   u32  cl_default_mds_easize;
+   u32  cl_max_mds_easize;
+   u32  cl_default_mds_cookiesize;
+   u32  cl_max_mds_cookiesize;
 
enum lustre_sec_part cl_sp_me;
enum lustre_sec_part cl_sp_to;
@@ -745,7 +745,7 @@ struct md_op_data {
struct lustre_handleop_handle;
s64 op_mod_time;
const char   *op_name;
-   int  op_namelen;
+   size_t  op_namelen;
__u32  op_mode;
struct lmv_stripe_md   *op_mea1;
struct lmv_stripe_md   *op_mea2;
@@ -976,8 +976,8 @@ struct md_ops {
int (*close)(struct obd_export *, struct md_op_data *,
 struct md_open_data *, struct ptlrpc_request **);
int (*create)(struct obd_export *, struct md_op_data *,
- const void *, int, int, __u32, __u32, cfs_cap_t,
- __u64, struct ptlrpc_request **);
+ const void *, size_t, umode_t, uid_t, gid_t,
+ cfs_cap_t, __u64, struct ptlrpc_request **);
int (*done_writing)(struct obd_export *, struct md_op_data  *,
struct md_open_data *);
int (*enqueue)(struct obd_export *, struct ldlm_enqueue_info *,
@@ -995,10 +995,10 @@ struct md_ops {
int (*link)(struct obd_export *, struct md_op_data *,
struct ptlrpc_request **);
int (*rename)(struct obd_export *, struct md_op_data *,
- const char *, int, const char *, int,
+ const char *, size_t, const char *, size_t,
  struct ptlrpc_request **);
int (*setattr)(struct obd_export *, struct md_op_data *, void *,
-  int, void *, int, struct ptlrpc_request **,
+  size_t, void *, size_t, struct ptlrpc_request **,
 struct md_open_data **mod);
int (*sync)(struct obd_export *, const struct lu_fid *,
struct ptlrpc_request **);
@@ -1016,7 +1016,7 @@ struct md_ops {
u64, const char *, const char *, int, int, int,
struct ptlrpc_request **);
 
-   int (*init_ea_size)(struct obd_export *, int, int, int, int);
+   int (*init_ea_size)(struct obd_export *, u32, u32, u32, u32);
 
int (*get_lustre_md)(struct obd_export *, struct ptlrpc_request *,
 struct obd_export *, struct obd_export *,
@@ -1139,7 +1139,8 @@ static inline const char *lu_dev_name(const struct 
lu_device *lu_dev)
return lu_dev->ld_obd->obd_name;
 }
 
-static inline bool filename_is_volatile(const char *name, int namelen, int 
*idx)
+static inline bool filename_is_volatile(const char *name, size_t namelen,
+   int *idx)
 {
const char  *start;
char*end;
diff --git