Re: [PATCH 1/2] gpio: ath79: Fix module autoload

2016-10-23 Thread Linus Walleij 
On Tue, Oct 18, 2016 at 10:44 PM, Javier Martinez Canillas
 wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> alias:  of:N*T*Cqca,ar9340-gpioC*
> alias:  of:N*T*Cqca,ar9340-gpio
> alias:  of:N*T*Cqca,ar7100-gpioC*
> alias:  of:N*T*Cqca,ar7100-gpio
>
> Signed-off-by: Javier Martinez Canillas 

Patch applied with Alban's ACK.

Yours,
Linus Walleij

Re: [PATCH 1/2] gpio: ath79: Fix module autoload

2016-10-23 Thread Linus Walleij 
On Tue, Oct 18, 2016 at 10:44 PM, Javier Martinez Canillas
 wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> alias:  of:N*T*Cqca,ar9340-gpioC*
> alias:  of:N*T*Cqca,ar9340-gpio
> alias:  of:N*T*Cqca,ar7100-gpioC*
> alias:  of:N*T*Cqca,ar7100-gpio
>
> Signed-off-by: Javier Martinez Canillas 

Patch applied with Alban's ACK.

Yours,
Linus Walleij

Re: [PATCH 1/2] gpio: ath79: Fix module autoload

2016-10-19 Thread Alban 
On Tue, 18 Oct 2016 17:44:01 -0300
Javier Martinez Canillas  wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> alias:  of:N*T*Cqca,ar9340-gpioC*
> alias:  of:N*T*Cqca,ar9340-gpio
> alias:  of:N*T*Cqca,ar7100-gpioC*
> alias:  of:N*T*Cqca,ar7100-gpio
> 
> Signed-off-by: Javier Martinez Canillas 

Acked-by: Aban Bedel 

Alban


signature.asc
Description: PGP signature

Re: [PATCH 1/2] gpio: ath79: Fix module autoload

2016-10-19 Thread Alban 
On Tue, 18 Oct 2016 17:44:01 -0300
Javier Martinez Canillas  wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> alias:  of:N*T*Cqca,ar9340-gpioC*
> alias:  of:N*T*Cqca,ar9340-gpio
> alias:  of:N*T*Cqca,ar7100-gpioC*
> alias:  of:N*T*Cqca,ar7100-gpio
> 
> Signed-off-by: Javier Martinez Canillas 

Acked-by: Aban Bedel 

Alban


signature.asc
Description: PGP signature

[PATCH 1/2] gpio: ath79: Fix module autoload

2016-10-18 Thread Javier Martinez Canillas 
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/gpio/gpio-ath79.ko | grep alias
$

After this patch:

$ modinfo drivers/gpio/gpio-ath79.ko | grep alias
alias:  of:N*T*Cqca,ar9340-gpioC*
alias:  of:N*T*Cqca,ar9340-gpio
alias:  of:N*T*Cqca,ar7100-gpioC*
alias:  of:N*T*Cqca,ar7100-gpio

Signed-off-by: Javier Martinez Canillas 
---

 drivers/gpio/gpio-ath79.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index 9457e2022bf6..dc37dbe4b46d 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -219,6 +219,7 @@ static const struct of_device_id ath79_gpio_of_match[] = {
{ .compatible = "qca,ar9340-gpio" },
{},
 };
+MODULE_DEVICE_TABLE(of, ath79_gpio_of_match);
 
 static int ath79_gpio_probe(struct platform_device *pdev)
 {
-- 
2.7.4

[PATCH 1/2] gpio: ath79: Fix module autoload

2016-10-18 Thread Javier Martinez Canillas 
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/gpio/gpio-ath79.ko | grep alias
$

After this patch:

$ modinfo drivers/gpio/gpio-ath79.ko | grep alias
alias:  of:N*T*Cqca,ar9340-gpioC*
alias:  of:N*T*Cqca,ar9340-gpio
alias:  of:N*T*Cqca,ar7100-gpioC*
alias:  of:N*T*Cqca,ar7100-gpio

Signed-off-by: Javier Martinez Canillas 
---

 drivers/gpio/gpio-ath79.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index 9457e2022bf6..dc37dbe4b46d 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -219,6 +219,7 @@ static const struct of_device_id ath79_gpio_of_match[] = {
{ .compatible = "qca,ar9340-gpio" },
{},
 };
+MODULE_DEVICE_TABLE(of, ath79_gpio_of_match);
 
 static int ath79_gpio_probe(struct platform_device *pdev)
 {
-- 
2.7.4