Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-23 Thread Rui Miguel Silva 

Hi Fabio,
On Thu 22 Feb 2018 at 11:31, Fabio Estevam wrote:
On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva 
 wrote:
Add device tree binding documentation for the OV5640 camera 
sensor.


s/OV5640/OV2680


Thanks for notice this ;).

---
Cheers,
Rui

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-23 Thread Rui Miguel Silva 

Hi Fabio,
On Thu 22 Feb 2018 at 11:31, Fabio Estevam wrote:
On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva 
 wrote:
Add device tree binding documentation for the OV5640 camera 
sensor.


s/OV5640/OV2680


Thanks for notice this ;).

---
Cheers,
Rui

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-23 Thread Rui Miguel Silva 

Hi Sakari,
Thanks for the review.

On Thu 22 Feb 2018 at 10:59, Sakari Ailus wrote:

Hi Rui,

Thanks for the patchset.

Could you use "dt: bindings: " prefix in the subject?


Sure, no problem.



On Thu, Feb 22, 2018 at 10:23:37AM +, Rui Miguel Silva 
wrote:
Add device tree binding documentation for the OV5640 camera 
sensor.


CC: devicet...@vger.kernel.org
Signed-off-by: Rui Miguel Silva 
---
 .../devicetree/bindings/media/i2c/ov2680.txt   | 34 
 ++

 1 file changed, 34 insertions(+)
 create mode 100644 
 Documentation/devicetree/bindings/media/i2c/ov2680.txt


diff --git 
a/Documentation/devicetree/bindings/media/i2c/ov2680.txt 
b/Documentation/devicetree/bindings/media/i2c/ov2680.txt

new file mode 100644
index ..f9dc63ce5044
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
@@ -0,0 +1,34 @@
+* Omnivision OV2680 MIPI CSI-2 sensor
+
+Required Properties:
+- compatible: should be "ovti,ov2680"
+- clocks: reference to the xvclk input clock.
+- clock-names: should be "xvclk".
+
+Optional Properties:
+- powerdown-gpios: reference to the GPIO connected to the 
powerdown pin,
+		 if any. This is an active high signal to the 
OV2680.

+
+The device node must contain one 'port' child node for its 
digital output


Please add that the port contains a single endpoint as well.


Ack.



+video port, in accordance with the video interface bindings 
defined in

+Documentation/devicetree/bindings/media/video-interfaces.txt.


Please list required and optional endpoint properties as well.


OK.

---
Cheers,
Rui




+
+Example:
+
+ {
+   ov2680: camera-sensor@36 {
+   compatible = "ovti,ov2680";
+   reg = <0x36>;
+   clocks = <>;
+   clock-names = "xvclk";
+   powerdown-gpios = < 3 GPIO_ACTIVE_HIGH>;
+
+   port {
+   ov2680_mipi_ep: endpoint {
+remote-endpoint = 
<_sensor_ep>;

+   clock-lanes = <0>;
+   data-lanes = <1>;
+   };
+   };
+   };
+};

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-23 Thread Rui Miguel Silva 

Hi Sakari,
Thanks for the review.

On Thu 22 Feb 2018 at 10:59, Sakari Ailus wrote:

Hi Rui,

Thanks for the patchset.

Could you use "dt: bindings: " prefix in the subject?


Sure, no problem.



On Thu, Feb 22, 2018 at 10:23:37AM +, Rui Miguel Silva 
wrote:
Add device tree binding documentation for the OV5640 camera 
sensor.


CC: devicet...@vger.kernel.org
Signed-off-by: Rui Miguel Silva 
---
 .../devicetree/bindings/media/i2c/ov2680.txt   | 34 
 ++

 1 file changed, 34 insertions(+)
 create mode 100644 
 Documentation/devicetree/bindings/media/i2c/ov2680.txt


diff --git 
a/Documentation/devicetree/bindings/media/i2c/ov2680.txt 
b/Documentation/devicetree/bindings/media/i2c/ov2680.txt

new file mode 100644
index ..f9dc63ce5044
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
@@ -0,0 +1,34 @@
+* Omnivision OV2680 MIPI CSI-2 sensor
+
+Required Properties:
+- compatible: should be "ovti,ov2680"
+- clocks: reference to the xvclk input clock.
+- clock-names: should be "xvclk".
+
+Optional Properties:
+- powerdown-gpios: reference to the GPIO connected to the 
powerdown pin,
+		 if any. This is an active high signal to the 
OV2680.

+
+The device node must contain one 'port' child node for its 
digital output


Please add that the port contains a single endpoint as well.


Ack.



+video port, in accordance with the video interface bindings 
defined in

+Documentation/devicetree/bindings/media/video-interfaces.txt.


Please list required and optional endpoint properties as well.


OK.

---
Cheers,
Rui




+
+Example:
+
+ {
+   ov2680: camera-sensor@36 {
+   compatible = "ovti,ov2680";
+   reg = <0x36>;
+   clocks = <>;
+   clock-names = "xvclk";
+   powerdown-gpios = < 3 GPIO_ACTIVE_HIGH>;
+
+   port {
+   ov2680_mipi_ep: endpoint {
+remote-endpoint = 
<_sensor_ep>;

+   clock-lanes = <0>;
+   data-lanes = <1>;
+   };
+   };
+   };
+};

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-22 Thread Fabio Estevam 
On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva  wrote:
> Add device tree binding documentation for the OV5640 camera sensor.

s/OV5640/OV2680

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-22 Thread Fabio Estevam 
On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva  wrote:
> Add device tree binding documentation for the OV5640 camera sensor.

s/OV5640/OV2680

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-22 Thread Sakari Ailus 
Hi Rui,

Thanks for the patchset.

Could you use "dt: bindings: " prefix in the subject?

On Thu, Feb 22, 2018 at 10:23:37AM +, Rui Miguel Silva wrote:
> Add device tree binding documentation for the OV5640 camera sensor.
> 
> CC: devicet...@vger.kernel.org
> Signed-off-by: Rui Miguel Silva 
> ---
>  .../devicetree/bindings/media/i2c/ov2680.txt   | 34 
> ++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2680.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt 
> b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
> new file mode 100644
> index ..f9dc63ce5044
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
> @@ -0,0 +1,34 @@
> +* Omnivision OV2680 MIPI CSI-2 sensor
> +
> +Required Properties:
> +- compatible: should be "ovti,ov2680"
> +- clocks: reference to the xvclk input clock.
> +- clock-names: should be "xvclk".
> +
> +Optional Properties:
> +- powerdown-gpios: reference to the GPIO connected to the powerdown pin,
> +  if any. This is an active high signal to the OV2680.
> +
> +The device node must contain one 'port' child node for its digital output

Please add that the port contains a single endpoint as well.

> +video port, in accordance with the video interface bindings defined in
> +Documentation/devicetree/bindings/media/video-interfaces.txt.

Please list required and optional endpoint properties as well.

> +
> +Example:
> +
> + {
> + ov2680: camera-sensor@36 {
> + compatible = "ovti,ov2680";
> + reg = <0x36>;
> + clocks = <>;
> + clock-names = "xvclk";
> + powerdown-gpios = < 3 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + ov2680_mipi_ep: endpoint {
> + remote-endpoint = <_sensor_ep>;
> + clock-lanes = <0>;
> + data-lanes = <1>;
> + };
> + };
> + };
> +};

-- 
Regards,

Sakari Ailus
sakari.ai...@linux.intel.com

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-22 Thread Sakari Ailus 
Hi Rui,

Thanks for the patchset.

Could you use "dt: bindings: " prefix in the subject?

On Thu, Feb 22, 2018 at 10:23:37AM +, Rui Miguel Silva wrote:
> Add device tree binding documentation for the OV5640 camera sensor.
> 
> CC: devicet...@vger.kernel.org
> Signed-off-by: Rui Miguel Silva 
> ---
>  .../devicetree/bindings/media/i2c/ov2680.txt   | 34 
> ++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2680.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt 
> b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
> new file mode 100644
> index ..f9dc63ce5044
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
> @@ -0,0 +1,34 @@
> +* Omnivision OV2680 MIPI CSI-2 sensor
> +
> +Required Properties:
> +- compatible: should be "ovti,ov2680"
> +- clocks: reference to the xvclk input clock.
> +- clock-names: should be "xvclk".
> +
> +Optional Properties:
> +- powerdown-gpios: reference to the GPIO connected to the powerdown pin,
> +  if any. This is an active high signal to the OV2680.
> +
> +The device node must contain one 'port' child node for its digital output

Please add that the port contains a single endpoint as well.

> +video port, in accordance with the video interface bindings defined in
> +Documentation/devicetree/bindings/media/video-interfaces.txt.

Please list required and optional endpoint properties as well.

> +
> +Example:
> +
> + {
> + ov2680: camera-sensor@36 {
> + compatible = "ovti,ov2680";
> + reg = <0x36>;
> + clocks = <>;
> + clock-names = "xvclk";
> + powerdown-gpios = < 3 GPIO_ACTIVE_HIGH>;
> +
> + port {
> + ov2680_mipi_ep: endpoint {
> + remote-endpoint = <_sensor_ep>;
> + clock-lanes = <0>;
> + data-lanes = <1>;
> + };
> + };
> + };
> +};

-- 
Regards,

Sakari Ailus
sakari.ai...@linux.intel.com

[PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-22 Thread Rui Miguel Silva 
Add device tree binding documentation for the OV5640 camera sensor.

CC: devicet...@vger.kernel.org
Signed-off-by: Rui Miguel Silva 
---
 .../devicetree/bindings/media/i2c/ov2680.txt   | 34 ++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2680.txt

diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt 
b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
new file mode 100644
index ..f9dc63ce5044
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
@@ -0,0 +1,34 @@
+* Omnivision OV2680 MIPI CSI-2 sensor
+
+Required Properties:
+- compatible: should be "ovti,ov2680"
+- clocks: reference to the xvclk input clock.
+- clock-names: should be "xvclk".
+
+Optional Properties:
+- powerdown-gpios: reference to the GPIO connected to the powerdown pin,
+if any. This is an active high signal to the OV2680.
+
+The device node must contain one 'port' child node for its digital output
+video port, in accordance with the video interface bindings defined in
+Documentation/devicetree/bindings/media/video-interfaces.txt.
+
+Example:
+
+ {
+   ov2680: camera-sensor@36 {
+   compatible = "ovti,ov2680";
+   reg = <0x36>;
+   clocks = <>;
+   clock-names = "xvclk";
+   powerdown-gpios = < 3 GPIO_ACTIVE_HIGH>;
+
+   port {
+   ov2680_mipi_ep: endpoint {
+   remote-endpoint = <_sensor_ep>;
+   clock-lanes = <0>;
+   data-lanes = <1>;
+   };
+   };
+   };
+};
-- 
2.16.2

[PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-22 Thread Rui Miguel Silva 
Add device tree binding documentation for the OV5640 camera sensor.

CC: devicet...@vger.kernel.org
Signed-off-by: Rui Miguel Silva 
---
 .../devicetree/bindings/media/i2c/ov2680.txt   | 34 ++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2680.txt

diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt 
b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
new file mode 100644
index ..f9dc63ce5044
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
@@ -0,0 +1,34 @@
+* Omnivision OV2680 MIPI CSI-2 sensor
+
+Required Properties:
+- compatible: should be "ovti,ov2680"
+- clocks: reference to the xvclk input clock.
+- clock-names: should be "xvclk".
+
+Optional Properties:
+- powerdown-gpios: reference to the GPIO connected to the powerdown pin,
+if any. This is an active high signal to the OV2680.
+
+The device node must contain one 'port' child node for its digital output
+video port, in accordance with the video interface bindings defined in
+Documentation/devicetree/bindings/media/video-interfaces.txt.
+
+Example:
+
+ {
+   ov2680: camera-sensor@36 {
+   compatible = "ovti,ov2680";
+   reg = <0x36>;
+   clocks = <>;
+   clock-names = "xvclk";
+   powerdown-gpios = < 3 GPIO_ACTIVE_HIGH>;
+
+   port {
+   ov2680_mipi_ep: endpoint {
+   remote-endpoint = <_sensor_ep>;
+   clock-lanes = <0>;
+   data-lanes = <1>;
+   };
+   };
+   };
+};
-- 
2.16.2