Re: [PATCH 1/2] media: ov7670: Add entity pads initialization

Hi Sakari, On 2017/8/16 0:23, Sakari Ailus wrote: Hi Wenyou, On Thu, Aug 10, 2017 at 05:06:44PM +0800, Wenyou Yang wrote: Add the media entity pads initialization. Signed-off-by: Wenyou Yang The patch itself seems fine. However the driver is lacking support for

Re: [PATCH 1/2] media: ov7670: Add entity pads initialization

Hi Sakari, On 2017/8/16 0:23, Sakari Ailus wrote: Hi Wenyou, On Thu, Aug 10, 2017 at 05:06:44PM +0800, Wenyou Yang wrote: Add the media entity pads initialization. Signed-off-by: Wenyou Yang The patch itself seems fine. However the driver is lacking support for get_fmt which I think would

Re: [PATCH 1/2] media: ov7670: Add entity pads initialization

Hi Wenyou, On Thu, Aug 10, 2017 at 05:06:44PM +0800, Wenyou Yang wrote: > Add the media entity pads initialization. > > Signed-off-by: Wenyou Yang The patch itself seems fine. However the driver is lacking support for get_fmt which I think would be necessary for the

Re: [PATCH 1/2] media: ov7670: Add entity pads initialization

Hi Wenyou, On Thu, Aug 10, 2017 at 05:06:44PM +0800, Wenyou Yang wrote: > Add the media entity pads initialization. > > Signed-off-by: Wenyou Yang The patch itself seems fine. However the driver is lacking support for get_fmt which I think would be necessary for the user space API to work

[PATCH 1/2] media: ov7670: Add entity pads initialization

Add the media entity pads initialization. Signed-off-by: Wenyou Yang --- drivers/media/i2c/ov7670.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index

[PATCH 1/2] media: ov7670: Add entity pads initialization

Add the media entity pads initialization. Signed-off-by: Wenyou Yang --- drivers/media/i2c/ov7670.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index e88549f0e704..5c8460ee65c3 100644 ---