[PATCH 1/2] perf: Add function to post process kernel trace events

[Ravi Bangoria]

Instead of inline code, introduce function to post process kernel
probe trace events.

Signed-off-by: Ravi Bangoria 
---
 tools/perf/util/probe-event.c | 29 ++---
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 953dc1a..4e215e7 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -664,22 +664,14 @@ static int add_module_to_probe_trace_events(struct 
probe_trace_event *tevs,
return ret;
 }
 
-/* Post processing the probe events */
-static int post_process_probe_trace_events(struct probe_trace_event *tevs,
-  int ntevs, const char *module,
-  bool uprobe)
+static int
+post_process_kernel_probe_trace_events(struct probe_trace_event *tevs,
+  int ntevs)
 {
struct ref_reloc_sym *reloc_sym;
char *tmp;
int i, skipped = 0;
 
-   if (uprobe)
-   return add_exec_to_probe_trace_events(tevs, ntevs, module);
-
-   /* Note that currently ref_reloc_sym based probe is not for drivers */
-   if (module)
-   return add_module_to_probe_trace_events(tevs, ntevs, module);
-
reloc_sym = kernel_get_ref_reloc_sym();
if (!reloc_sym) {
pr_warning("Relocated base symbol is not found!\n");
@@ -711,6 +703,21 @@ static int post_process_probe_trace_events(struct 
probe_trace_event *tevs,
return skipped;
 }
 
+/* Post processing the probe events */
+static int post_process_probe_trace_events(struct probe_trace_event *tevs,
+  int ntevs, const char *module,
+  bool uprobe)
+{
+   if (uprobe)
+   return add_exec_to_probe_trace_events(tevs, ntevs, module);
+
+   if (module)
+   /* Currently ref_reloc_sym based probe is not for drivers */
+   return add_module_to_probe_trace_events(tevs, ntevs, module);
+
+   return post_process_kernel_probe_trace_events(tevs, ntevs);
+}
+
 /* Try to find perf_probe_event with debuginfo */
 static int try_to_find_probe_trace_events(struct perf_probe_event *pev,
  struct probe_trace_event **tevs)
-- 
2.7.4

[PATCH 1/2] perf: Add function to post process kernel trace events

[Ravi Bangoria]

Instead of inline code, introduce function to post process kernel
probe trace events.

Signed-off-by: Ravi Bangoria 
---
 tools/perf/util/probe-event.c | 29 ++---
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 953dc1a..4e215e7 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -664,22 +664,14 @@ static int add_module_to_probe_trace_events(struct 
probe_trace_event *tevs,
return ret;
 }
 
-/* Post processing the probe events */
-static int post_process_probe_trace_events(struct probe_trace_event *tevs,
-  int ntevs, const char *module,
-  bool uprobe)
+static int
+post_process_kernel_probe_trace_events(struct probe_trace_event *tevs,
+  int ntevs)
 {
struct ref_reloc_sym *reloc_sym;
char *tmp;
int i, skipped = 0;
 
-   if (uprobe)
-   return add_exec_to_probe_trace_events(tevs, ntevs, module);
-
-   /* Note that currently ref_reloc_sym based probe is not for drivers */
-   if (module)
-   return add_module_to_probe_trace_events(tevs, ntevs, module);
-
reloc_sym = kernel_get_ref_reloc_sym();
if (!reloc_sym) {
pr_warning("Relocated base symbol is not found!\n");
@@ -711,6 +703,21 @@ static int post_process_probe_trace_events(struct 
probe_trace_event *tevs,
return skipped;
 }
 
+/* Post processing the probe events */
+static int post_process_probe_trace_events(struct probe_trace_event *tevs,
+  int ntevs, const char *module,
+  bool uprobe)
+{
+   if (uprobe)
+   return add_exec_to_probe_trace_events(tevs, ntevs, module);
+
+   if (module)
+   /* Currently ref_reloc_sym based probe is not for drivers */
+   return add_module_to_probe_trace_events(tevs, ntevs, module);
+
+   return post_process_kernel_probe_trace_events(tevs, ntevs);
+}
+
 /* Try to find perf_probe_event with debuginfo */
 static int try_to_find_probe_trace_events(struct perf_probe_event *pev,
  struct probe_trace_event **tevs)
-- 
2.7.4