Re: [PATCH 1/2] vsprintf: Tweak pF/pf comment

[Petr Mladek]

On Sat 2018-04-14 12:00:05, Sergey Senozhatsky wrote:
> Reflect changes that have happened to pf/pF (deprecation)
> specifiers in pointer() comment section.
> 
> Signed-off-by: Sergey Senozhatsky 

Good catch!

Reviewed-by: Petr Mladek 

I have pushed this into printk.git, branch for-4.18-vsprintf-cleanup.

Best Regards,
Petr

Re: [PATCH 1/2] vsprintf: Tweak pF/pf comment

[Petr Mladek]

On Sat 2018-04-14 12:00:05, Sergey Senozhatsky wrote:
> Reflect changes that have happened to pf/pF (deprecation)
> specifiers in pointer() comment section.
> 
> Signed-off-by: Sergey Senozhatsky 

Good catch!

Reviewed-by: Petr Mladek 

I have pushed this into printk.git, branch for-4.18-vsprintf-cleanup.

Best Regards,
Petr

[PATCH 1/2] vsprintf: Tweak pF/pf comment

[Sergey Senozhatsky]

Reflect changes that have happened to pf/pF (deprecation)
specifiers in pointer() comment section.

Signed-off-by: Sergey Senozhatsky 
---
 lib/vsprintf.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 30c0cb8cc9bc..dd18bb2a56ef 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1746,10 +1746,10 @@ static char *ptr_to_id(char *buf, char *end, void *ptr, 
struct printf_spec spec)
  *
  * Right now we handle:
  *
- * - 'F' For symbolic function descriptor pointers with offset
- * - 'f' For simple symbolic function names without offset
- * - 'S' For symbolic direct pointers with offset
- * - 's' For symbolic direct pointers without offset
+ * - 'S' For symbolic direct pointers (or function descriptors) with offset
+ * - 's' For symbolic direct pointers (or function descriptors) without offset
+ * - 'F' Same as 'S'
+ * - 'f' Same as 's'
  * - '[FfSs]R' as above with __builtin_extract_return_addr() translation
  * - 'B' For backtraced symbolic direct pointers with offset
  * - 'R' For decoded struct resource, e.g., [mem 0x0-0x1f 64bit pref]
@@ -1846,10 +1846,6 @@ static char *ptr_to_id(char *buf, char *end, void *ptr, 
struct printf_spec spec)
  * ** When making changes please also update:
  * Documentation/core-api/printk-formats.rst
  *
- * Note: The difference between 'S' and 'F' is that on ia64 and ppc64
- * function pointers are really function descriptors, which contain a
- * pointer to the real address.
- *
  * Note: The default behaviour (unadorned %p) is to hash the address,
  * rendering it useful as a unique identifier.
  */
-- 
2.17.0

[PATCH 1/2] vsprintf: Tweak pF/pf comment

[Sergey Senozhatsky]

Reflect changes that have happened to pf/pF (deprecation)
specifiers in pointer() comment section.

Signed-off-by: Sergey Senozhatsky 
---
 lib/vsprintf.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 30c0cb8cc9bc..dd18bb2a56ef 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1746,10 +1746,10 @@ static char *ptr_to_id(char *buf, char *end, void *ptr, 
struct printf_spec spec)
  *
  * Right now we handle:
  *
- * - 'F' For symbolic function descriptor pointers with offset
- * - 'f' For simple symbolic function names without offset
- * - 'S' For symbolic direct pointers with offset
- * - 's' For symbolic direct pointers without offset
+ * - 'S' For symbolic direct pointers (or function descriptors) with offset
+ * - 's' For symbolic direct pointers (or function descriptors) without offset
+ * - 'F' Same as 'S'
+ * - 'f' Same as 's'
  * - '[FfSs]R' as above with __builtin_extract_return_addr() translation
  * - 'B' For backtraced symbolic direct pointers with offset
  * - 'R' For decoded struct resource, e.g., [mem 0x0-0x1f 64bit pref]
@@ -1846,10 +1846,6 @@ static char *ptr_to_id(char *buf, char *end, void *ptr, 
struct printf_spec spec)
  * ** When making changes please also update:
  * Documentation/core-api/printk-formats.rst
  *
- * Note: The difference between 'S' and 'F' is that on ia64 and ppc64
- * function pointers are really function descriptors, which contain a
- * pointer to the real address.
- *
  * Note: The default behaviour (unadorned %p) is to hash the address,
  * rendering it useful as a unique identifier.
  */
-- 
2.17.0