Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

2018-03-07 Thread Lee Jones
On Wed, 07 Mar 2018, Lee Jones wrote: > On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote: > > > From: Vincent Palatin > > > > If we cannot communicate with the EC chip to detect the protocol version > > and its features, it's very likely useless to continue. Else we

Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

2018-03-07 Thread Lee Jones
On Wed, 07 Mar 2018, Lee Jones wrote: > On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote: > > > From: Vincent Palatin > > > > If we cannot communicate with the EC chip to detect the protocol version > > and its features, it's very likely useless to continue. Else we will > > commit all kind

Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

2018-03-07 Thread Lee Jones
On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote: > From: Vincent Palatin > > If we cannot communicate with the EC chip to detect the protocol version > and its features, it's very likely useless to continue. Else we will > commit all kind of uninformed mistakes (using

Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

2018-03-07 Thread Lee Jones
On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote: > From: Vincent Palatin > > If we cannot communicate with the EC chip to detect the protocol version > and its features, it's very likely useless to continue. Else we will > commit all kind of uninformed mistakes (using the wrong protocol, the

Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

2018-02-21 Thread Gwendal Grignou
On Mon, Feb 19, 2018 at 2:46 PM, Enric Balletbo i Serra wrote: > From: Vincent Palatin > > If we cannot communicate with the EC chip to detect the protocol version > and its features, it's very likely useless to continue. Else we will > commit

Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

2018-02-21 Thread Gwendal Grignou
On Mon, Feb 19, 2018 at 2:46 PM, Enric Balletbo i Serra wrote: > From: Vincent Palatin > > If we cannot communicate with the EC chip to detect the protocol version > and its features, it's very likely useless to continue. Else we will > commit all kind of uninformed mistakes (using the wrong

[PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

2018-02-19 Thread Enric Balletbo i Serra
From: Vincent Palatin If we cannot communicate with the EC chip to detect the protocol version and its features, it's very likely useless to continue. Else we will commit all kind of uninformed mistakes (using the wrong protocol, the wrong buffer size, mixing the EC with

[PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

2018-02-19 Thread Enric Balletbo i Serra
From: Vincent Palatin If we cannot communicate with the EC chip to detect the protocol version and its features, it's very likely useless to continue. Else we will commit all kind of uninformed mistakes (using the wrong protocol, the wrong buffer size, mixing the EC with other chips).