Re: [PATCH 1/7] tools: build: Fixup host c flags
On Fri, Jul 06, 2018 at 06:07:03PM -0700, Laura Abbott wrote: > Commit 0c3b7e42616f ("tools build: Add support for host programs format") > introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the > variable is HOSTCFLAGS. Fix this up. > > Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") > Signed-off-by: Laura Abbott > --- > This seemed like a typo to the best of my understanding and certain > things wouldn't link properly until this was fixed. ugh, thanks for finding this.. I think/hope it's typo ;-) please also change the only perf user of this: tools/perf/pmu-events/Build:CHOSTFLAGS_jevents.o = -I$(srctree)/tools/include jirka > --- > tools/build/Build.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/build/Build.include b/tools/build/Build.include > index a4bbb984941d..b5c679cd441c 100644 > --- a/tools/build/Build.include > +++ b/tools/build/Build.include > @@ -98,4 +98,4 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) > -D"BUILD_STR(s)=\#s" $(CXX > ### > ## HOSTCC C flags > > -host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CHOSTFLAGS) > -D"BUILD_STR(s)=\#s" $(CHOSTFLAGS_$(basetarget).o) $(CHOSTFLAGS_$(obj)) > +host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) > -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) > -- > 2.17.1 >
Re: [PATCH 1/7] tools: build: Fixup host c flags
On Fri, Jul 06, 2018 at 06:07:03PM -0700, Laura Abbott wrote: > Commit 0c3b7e42616f ("tools build: Add support for host programs format") > introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the > variable is HOSTCFLAGS. Fix this up. > > Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") > Signed-off-by: Laura Abbott > --- > This seemed like a typo to the best of my understanding and certain > things wouldn't link properly until this was fixed. ugh, thanks for finding this.. I think/hope it's typo ;-) please also change the only perf user of this: tools/perf/pmu-events/Build:CHOSTFLAGS_jevents.o = -I$(srctree)/tools/include jirka > --- > tools/build/Build.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/build/Build.include b/tools/build/Build.include > index a4bbb984941d..b5c679cd441c 100644 > --- a/tools/build/Build.include > +++ b/tools/build/Build.include > @@ -98,4 +98,4 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) > -D"BUILD_STR(s)=\#s" $(CXX > ### > ## HOSTCC C flags > > -host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CHOSTFLAGS) > -D"BUILD_STR(s)=\#s" $(CHOSTFLAGS_$(basetarget).o) $(CHOSTFLAGS_$(obj)) > +host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) > -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) > -- > 2.17.1 >
[PATCH 1/7] tools: build: Fixup host c flags
Commit 0c3b7e42616f ("tools build: Add support for host programs format") introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the variable is HOSTCFLAGS. Fix this up. Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") Signed-off-by: Laura Abbott --- This seemed like a typo to the best of my understanding and certain things wouldn't link properly until this was fixed. --- tools/build/Build.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/build/Build.include b/tools/build/Build.include index a4bbb984941d..b5c679cd441c 100644 --- a/tools/build/Build.include +++ b/tools/build/Build.include @@ -98,4 +98,4 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) -D"BUILD_STR(s)=\#s" $(CXX ### ## HOSTCC C flags -host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CHOSTFLAGS) -D"BUILD_STR(s)=\#s" $(CHOSTFLAGS_$(basetarget).o) $(CHOSTFLAGS_$(obj)) +host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) -- 2.17.1
[PATCH 1/7] tools: build: Fixup host c flags
Commit 0c3b7e42616f ("tools build: Add support for host programs format") introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the variable is HOSTCFLAGS. Fix this up. Fixes: 0c3b7e42616f ("tools build: Add support for host programs format") Signed-off-by: Laura Abbott --- This seemed like a typo to the best of my understanding and certain things wouldn't link properly until this was fixed. --- tools/build/Build.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/build/Build.include b/tools/build/Build.include index a4bbb984941d..b5c679cd441c 100644 --- a/tools/build/Build.include +++ b/tools/build/Build.include @@ -98,4 +98,4 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) -D"BUILD_STR(s)=\#s" $(CXX ### ## HOSTCC C flags -host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CHOSTFLAGS) -D"BUILD_STR(s)=\#s" $(CHOSTFLAGS_$(basetarget).o) $(CHOSTFLAGS_$(obj)) +host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) -- 2.17.1