Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-08 Thread Hans de Goede
Hi, On 08/08/2017 04:42 PM, Mark Brown wrote: On Tue, Aug 08, 2017 at 02:56:46PM +0100, Hans de Goede wrote: Hi, Please don't take things off-list unless there is a really strong reason to do so. Sending things to the list ensures that everyone gets a chance to read and comment on things.

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-08 Thread Hans de Goede
Hi, On 08/08/2017 04:42 PM, Mark Brown wrote: On Tue, Aug 08, 2017 at 02:56:46PM +0100, Hans de Goede wrote: Hi, Please don't take things off-list unless there is a really strong reason to do so. Sending things to the list ensures that everyone gets a chance to read and comment on things.

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-08 Thread Mark Brown
On Mon, Aug 07, 2017 at 09:20:05PM +0200, Hans de Goede wrote: > On 07-08-17 17:41, Mark Brown wrote: > > I2C has a perfectly good platform_data pointer in the board info for > > this stuff. > True, so you are suggesting that I define a bq24190_platform_data > struct with a regulator_init_data

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-08 Thread Mark Brown
On Mon, Aug 07, 2017 at 09:20:05PM +0200, Hans de Goede wrote: > On 07-08-17 17:41, Mark Brown wrote: > > I2C has a perfectly good platform_data pointer in the board info for > > this stuff. > True, so you are suggesting that I define a bq24190_platform_data > struct with a regulator_init_data

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Hans de Goede
Hi, On 07-08-17 17:41, Mark Brown wrote: On Mon, Aug 07, 2017 at 04:41:18PM +0200, Hans de Goede wrote: On 07-08-17 13:10, Mark Brown wrote: Problem 1) The regulator in question is part of the bq24292i charger-IC attached to a private i2c bus between the PMIC and the charger. The driver

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Hans de Goede
Hi, On 07-08-17 17:41, Mark Brown wrote: On Mon, Aug 07, 2017 at 04:41:18PM +0200, Hans de Goede wrote: On 07-08-17 13:10, Mark Brown wrote: Problem 1) The regulator in question is part of the bq24292i charger-IC attached to a private i2c bus between the PMIC and the charger. The driver

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Mark Brown
On Mon, Aug 07, 2017 at 04:41:18PM +0200, Hans de Goede wrote: > On 07-08-17 13:10, Mark Brown wrote: > Problem 1) > The regulator in question is part of the bq24292i charger-IC attached to > a private i2c bus between the PMIC and the charger. The driver for the i2c > controller inside the PMIC

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Mark Brown
On Mon, Aug 07, 2017 at 04:41:18PM +0200, Hans de Goede wrote: > On 07-08-17 13:10, Mark Brown wrote: > Problem 1) > The regulator in question is part of the bq24292i charger-IC attached to > a private i2c bus between the PMIC and the charger. The driver for the i2c > controller inside the PMIC

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Hans de Goede
Hi Mark, On 07-08-17 13:10, Mark Brown wrote: On Sun, Aug 06, 2017 at 05:44:36PM +0200, Hans de Goede wrote: On 06-08-17 16:30, Guenter Roeck wrote: On 08/06/2017 05:35 AM, Hans de Goede wrote: On ACPI platforms, there are no phandles and we need to get the vbus by a system wide unique

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Hans de Goede
Hi Mark, On 07-08-17 13:10, Mark Brown wrote: On Sun, Aug 06, 2017 at 05:44:36PM +0200, Hans de Goede wrote: On 06-08-17 16:30, Guenter Roeck wrote: On 08/06/2017 05:35 AM, Hans de Goede wrote: On ACPI platforms, there are no phandles and we need to get the vbus by a system wide unique

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Mark Brown
On Sun, Aug 06, 2017 at 05:44:36PM +0200, Hans de Goede wrote: > On 06-08-17 16:30, Guenter Roeck wrote: > > On 08/06/2017 05:35 AM, Hans de Goede wrote: > > > On ACPI platforms, there are no phandles and we need to get the vbus by a > > > system wide unique name. Add support for a new

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Mark Brown
On Sun, Aug 06, 2017 at 05:44:36PM +0200, Hans de Goede wrote: > On 06-08-17 16:30, Guenter Roeck wrote: > > On 08/06/2017 05:35 AM, Hans de Goede wrote: > > > On ACPI platforms, there are no phandles and we need to get the vbus by a > > > system wide unique name. Add support for a new

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Hans de Goede
Hi, On 06-08-17 16:30, Guenter Roeck wrote: On 08/06/2017 05:35 AM, Hans de Goede wrote: On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and we need to get the vbus by a system wide

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Hans de Goede
Hi, On 06-08-17 16:30, Guenter Roeck wrote: On 08/06/2017 05:35 AM, Hans de Goede wrote: On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and we need to get the vbus by a system wide

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Guenter Roeck
On 08/06/2017 07:52 AM, Hans de Goede wrote: Hi, On 06-08-17 16:30, Guenter Roeck wrote: On 08/06/2017 05:35 AM, Hans de Goede wrote: On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Guenter Roeck
On 08/06/2017 07:52 AM, Hans de Goede wrote: Hi, On 06-08-17 16:30, Guenter Roeck wrote: On 08/06/2017 05:35 AM, Hans de Goede wrote: On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Hans de Goede
Hi, On 06-08-17 16:30, Guenter Roeck wrote: On 08/06/2017 05:35 AM, Hans de Goede wrote: On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and we need to get the vbus by a system wide

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Hans de Goede
Hi, On 06-08-17 16:30, Guenter Roeck wrote: On 08/06/2017 05:35 AM, Hans de Goede wrote: On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and we need to get the vbus by a system wide

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Guenter Roeck
On 08/06/2017 05:35 AM, Hans de Goede wrote: On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and we need to get the vbus by a system wide unique name. Add support for a new

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Guenter Roeck
On 08/06/2017 05:35 AM, Hans de Goede wrote: On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and we need to get the vbus by a system wide unique name. Add support for a new

[PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Hans de Goede
On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and we need to get the vbus by a system wide unique name. Add support for a new "fcs,vbus-regulator-name" device-property which ACPI platform

[PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-06 Thread Hans de Goede
On devicetree platforms the fusb302 dt-node will have a vbus regulator property with a phandle to the regulator. On ACPI platforms, there are no phandles and we need to get the vbus by a system wide unique name. Add support for a new "fcs,vbus-regulator-name" device-property which ACPI platform