Re: [PATCH 11/14] staging: fsl-mc: message cleanup

2016-10-25 Thread Greg KH
On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote: > Cleanup and clarify messages > -use "fsl-mc" prefix for all messages that don't come from dev_* >functions Nope, please use the proper pr_fmt() #define at the top of the file, that way you don't have to put the string into all

Re: [PATCH 11/14] staging: fsl-mc: message cleanup

2016-10-25 Thread Greg KH
On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote: > Cleanup and clarify messages > -use "fsl-mc" prefix for all messages that don't come from dev_* >functions Nope, please use the proper pr_fmt() #define at the top of the file, that way you don't have to put the string into all

[PATCH 11/14] staging: fsl-mc: message cleanup

2016-10-17 Thread Stuart Yoder
Cleanup and clarify messages -use "fsl-mc" prefix for all messages that don't come from dev_* functions -remove unnecessary verbosity to make things clearer -use explicit __func__ arguments to clarify some error messages -improve misc wording for clarity Signed-off-by: Stuart Yoder

[PATCH 11/14] staging: fsl-mc: message cleanup

2016-10-17 Thread Stuart Yoder
Cleanup and clarify messages -use "fsl-mc" prefix for all messages that don't come from dev_* functions -remove unnecessary verbosity to make things clearer -use explicit __func__ arguments to clarify some error messages -improve misc wording for clarity Signed-off-by: Stuart Yoder