Re: [PATCH 12/15] ARM64: dts: r8a77965: Add GPIO nodes

[Geert Uytterhoeven]

On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi
 wrote:
> Add GPIO nodes to r8a77965 SoC device tree file.
>
> Signed-off-by: Jacopo Mondi 

Reviewed-by: Geert Uytterhoeven 

> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -201,38 +201,6 @@
> #power-domain-cells = <1>;
> };
>
> -   gpio0: gpio@e605 {
> -   /* placeholder */
> -   };
> -
> -   gpio1: gpio@e6051000 {
> -   /* placeholder */
> -   };
> -
> -   gpio2: gpio@e6052000 {
> -   /* placeholder */
> -   };
> -
> -   gpio3: gpio@e6053000 {
> -   /* placeholder */
> -   };
> -
> -   gpio4: gpio@e6054000 {
> -   /* placeholder */
> -   };
> -
> -   gpio5: gpio@e6055000 {
> -   /* placeholder */
> -   };
> -
> -   gpio6: gpio@e6055400 {
> -   /* placeholder */
> -   };
> -
> -   gpio7: gpio@e6055800 {
> -   /* placeholder */
> -   };
> -
> intc_ex: interrupt-controller@e61c {
> /* placeholder */
> };
> @@ -339,6 +307,126 @@
> dma-channels = <16>;
> };
>
> +   gpio0: gpio@e605 {

Why have you moved them?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 12/15] ARM64: dts: r8a77965: Add GPIO nodes

[Jacopo Mondi]

Add GPIO nodes to r8a77965 SoC device tree file.

Signed-off-by: Jacopo Mondi 
---
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 152 +++---
 1 file changed, 120 insertions(+), 32 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 236592b..71f20c3 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -201,38 +201,6 @@
#power-domain-cells = <1>;
};
 
-   gpio0: gpio@e605 {
-   /* placeholder */
-   };
-
-   gpio1: gpio@e6051000 {
-   /* placeholder */
-   };
-
-   gpio2: gpio@e6052000 {
-   /* placeholder */
-   };
-
-   gpio3: gpio@e6053000 {
-   /* placeholder */
-   };
-
-   gpio4: gpio@e6054000 {
-   /* placeholder */
-   };
-
-   gpio5: gpio@e6055000 {
-   /* placeholder */
-   };
-
-   gpio6: gpio@e6055400 {
-   /* placeholder */
-   };
-
-   gpio7: gpio@e6055800 {
-   /* placeholder */
-   };
-
intc_ex: interrupt-controller@e61c {
/* placeholder */
};
@@ -339,6 +307,126 @@
dma-channels = <16>;
};
 
+   gpio0: gpio@e605 {
+   compatible = "renesas,gpio-r8a77965",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe605 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = <&pfc 0 0 16>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = <&cpg CPG_MOD 912>;
+   power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+   resets = <&cpg 912>;
+   };
+
+   gpio1: gpio@e6051000 {
+   compatible = "renesas,gpio-r8a77965",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe6051000 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = <&pfc 0 32 29>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = <&cpg CPG_MOD 911>;
+   power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+   resets = <&cpg 911>;
+   };
+
+   gpio2: gpio@e6052000 {
+   compatible = "renesas,gpio-r8a77965",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe6052000 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = <&pfc 0 64 15>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = <&cpg CPG_MOD 910>;
+   power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+   resets = <&cpg 910>;
+   };
+
+   gpio3: gpio@e6053000 {
+   compatible = "renesas,gpio-r8a77965",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe6053000 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = <&pfc 0 96 16>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = <&cpg CPG_MOD 909>;
+   power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+   resets = <&cpg 909>;
+   };
+
+   gpio4: gpio@e6054000 {
+   compatible = "renesas,gpio-r8a77965",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe6054000 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = <&pfc 0 128 18>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = <&cpg CPG_MOD 908>;
+   power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+   resets = <&cpg 908>;
+   };
+
+   gpio5: gpio@e6055000 {
+