[PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-11-20 Thread Joerg Roedel
This call-back points to the right function for initializing the msi_msg structure. The old code for msi_msg generation was split up into the irq-remapped and the default case. The irq-remapped case just calls into the specific Intel or AMD implementation when the device is behind an IOMMU.

[PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-11-20 Thread Joerg Roedel
This call-back points to the right function for initializing the msi_msg structure. The old code for msi_msg generation was split up into the irq-remapped and the default case. The irq-remapped case just calls into the specific Intel or AMD implementation when the device is behind an IOMMU.

[PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-09-26 Thread Joerg Roedel
This call-back points to the right function for initializing the msi_msg structure. The old code for msi_msg generation was split up into the irq-remapped and the default case. The irq-remapped case just calls into the specific Intel or AMD implementation when the device is behind an IOMMU.

[PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-09-26 Thread Joerg Roedel
This call-back points to the right function for initializing the msi_msg structure. The old code for msi_msg generation was split up into the irq-remapped and the default case. The irq-remapped case just calls into the specific Intel or AMD implementation when the device is behind an IOMMU.

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-09-25 Thread Joerg Roedel
On Sun, Aug 26, 2012 at 08:41:40PM +0200, Sebastian Andrzej Siewior wrote: > On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > > This call-back points to the right function for initializing > > the msi_msg structure. > > So you pull out the compose_remapped_msi_msg() out of

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-09-25 Thread Joerg Roedel
On Sun, Aug 26, 2012 at 08:41:40PM +0200, Sebastian Andrzej Siewior wrote: On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: This call-back points to the right function for initializing the msi_msg structure. So you pull out the compose_remapped_msi_msg() out of

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > This call-back points to the right function for initializing > the msi_msg structure. So you pull out the compose_remapped_msi_msg() out of msi_compose_msg() and put this in a callback. Such information is good since you don't see

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-26 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: This call-back points to the right function for initializing the msi_msg structure. So you pull out the compose_remapped_msi_msg() out of msi_compose_msg() and put this in a callback. Such information is good since you don't see this

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-22 Thread Joerg Roedel
On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: > > On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > > > > This

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-22 Thread Joerg Roedel
On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: This call-back points

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-21 Thread Joerg Roedel
On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: > > On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > > > > This

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-21 Thread Joerg Roedel
On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: > > The VT-d implementation uses it. This function is used to create the MSI > > message for PCI devices and the HPET. When it is called for the HPET the > > pdev

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-21 Thread Konrad Rzeszutek Wilk
On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: > On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > > > This call-back points to the right function for initializing > > > the msi_msg structure. >

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-21 Thread Joerg Roedel
On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > > This call-back points to the right function for initializing > > the msi_msg structure. > > What is the 'hpet_id' purpose in this? The VT-d implementation

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-21 Thread Joerg Roedel
On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: This call-back points to the right function for initializing the msi_msg structure. What is the 'hpet_id' purpose in this? The VT-d implementation uses it.

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-21 Thread Konrad Rzeszutek Wilk
On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: This call-back points to the right function for initializing the msi_msg structure. What

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-21 Thread Joerg Roedel
On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: The VT-d implementation uses it. This function is used to create the MSI message for PCI devices and the HPET. When it is called for the HPET the pdev

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-21 Thread Joerg Roedel
On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: This call-back points

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-20 Thread Konrad Rzeszutek Wilk
On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > This call-back points to the right function for initializing > the msi_msg structure. What is the 'hpet_id' purpose in this? > > Signed-off-by: Joerg Roedel > --- > arch/x86/include/asm/io_apic.h |4 +++ >

[PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-20 Thread Joerg Roedel
This call-back points to the right function for initializing the msi_msg structure. Signed-off-by: Joerg Roedel --- arch/x86/include/asm/io_apic.h |4 +++ arch/x86/include/asm/x86_init.h |4 +++ arch/x86/kernel/apic/io_apic.c | 59 ---

[PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-20 Thread Joerg Roedel
This call-back points to the right function for initializing the msi_msg structure. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/include/asm/io_apic.h |4 +++ arch/x86/include/asm/x86_init.h |4 +++ arch/x86/kernel/apic/io_apic.c | 59

Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-20 Thread Konrad Rzeszutek Wilk
On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: This call-back points to the right function for initializing the msi_msg structure. What is the 'hpet_id' purpose in this? Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/include/asm/io_apic.h |4 +++

[PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-07 Thread Joerg Roedel
This call-back points to the right function for initializing the msi_msg structure. Signed-off-by: Joerg Roedel --- arch/x86/include/asm/io_apic.h |3 +++ arch/x86/include/asm/x86_init.h |4 +++ arch/x86/kernel/apic/io_apic.c | 57 ---

[PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back

2012-08-07 Thread Joerg Roedel
This call-back points to the right function for initializing the msi_msg structure. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/include/asm/io_apic.h |3 +++ arch/x86/include/asm/x86_init.h |4 +++ arch/x86/kernel/apic/io_apic.c | 57