Re: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

2018-03-12 Thread Arnd Bergmann
On Mon, Mar 12, 2018 at 12:43 PM, Tomer Maimon wrote: > Before entering the long mail (sorry about it) just a technical thing > I think we should add ARM_GIC configuration, It is not implied in > ARCH_MULTI_V7. Yes, you are right. > Now for the real story :-) > > The NPCM7xx is a family of BMC'

Re: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

2018-03-12 Thread Tomer Maimon
Hi Arnd, Please discard my previous mail, (I have more things to ask... please read this mail) Sorry for the delayed reply, Before entering the long mail (sorry about it) just a technical thing I think we should add ARM_GIC configuration, It is not implied in ARCH_MULTI_V7. Now for the real sto

Re: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

2018-03-12 Thread Tomer Maimon
Hi Amd, Sorry for the delayed reply, the NPCM7xx is a family of BMC's that include NPCM750, NPCM730 and more All of the NPCM7xx BMC's have the same basic modules like Cortex-A9, WDT, timers and more can we reflacte the NPCM7xx as follow in the Kconfig: menuconfig ARCH_NPCM bool "Nuvoto

Re: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

2018-03-08 Thread Arnd Bergmann
On Thu, Mar 8, 2018 at 11:46 AM, Avi Fishman wrote: > So at least replace CACHE_L2X0 with MIGHT_HAVE_CACHE_L2X0 then > CACHE_L2X0 will be selected by default and user can still remove it. I looked at the other platforms for this one again, and found that most simply select CONFIG_CACHE_L2X0 direc

Re: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

2018-03-08 Thread Avi Fishman
So at least replace CACHE_L2X0 with MIGHT_HAVE_CACHE_L2X0 then CACHE_L2X0 will be selected by default and user can still remove it. On Thu, Mar 8, 2018 at 4:12 AM, Joel Stanley wrote: > On Thu, Mar 8, 2018 at 2:54 AM, Arnd Bergmann wrote: >> While looking at the build regression, I noticed that

Re: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

2018-03-07 Thread Joel Stanley
On Thu, Mar 8, 2018 at 2:54 AM, Arnd Bergmann wrote: > While looking at the build regression, I noticed that the > platform selects a lot of other Kconfig symbols that it really > should not: > > CPU_V7, ARM_GIC, HAVE_SMP, COMMON_CLK, GENERIC_CLOCKEVENTS, > and CLKDEV_LOOKUP are all implied by ARC

[PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

2018-03-07 Thread Arnd Bergmann
While looking at the build regression, I noticed that the platform selects a lot of other Kconfig symbols that it really should not: CPU_V7, ARM_GIC, HAVE_SMP, COMMON_CLK, GENERIC_CLOCKEVENTS, and CLKDEV_LOOKUP are all implied by ARCH_MULTI_V7, so they can be dropped. CACHE_L2X0, SMP and USB are