Re: [PATCH 2/2] drivers/mmc/host/vub300.c: add missing usb_free_urb

[Chris Ball]

Hi Julia,

On Tue, Jul 24 2012, Julia Lawall wrote:
> From: Julia Lawall 
>
> Add missing usb_free_urb on failure path after usb_alloc_urb.

Thanks, pushed to mmc-next for 3.7.

- Chris.
-- 
Chris Ball  
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] drivers/mmc/host/vub300.c: add missing usb_free_urb

[Chris Ball]

Hi Julia,

On Tue, Jul 24 2012, Julia Lawall wrote:
 From: Julia Lawall julia.law...@lip6.fr

 Add missing usb_free_urb on failure path after usb_alloc_urb.

Thanks, pushed to mmc-next for 3.7.

- Chris.
-- 
Chris Ball   c...@laptop.org   http://printf.net/
One Laptop Per Child
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] drivers/mmc/host/vub300.c: add missing usb_free_urb

[Julia Lawall]

From: Julia Lawall 

Add missing usb_free_urb on failure path after usb_alloc_urb.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@km exists@
local idexpression e;
expression e1,e2,e3;
type T,T1;
identifier f;
@@

* e = usb_alloc_urb(...)
... when any
when != e = e1
when != e1 = (T)e
when != e1(...,(T)e,...)
when != >f
if(...) { ... when != e2(...,(T1)e,...)
 when != e3 = e
 when forall
(
 return <+...e...+>;
|
* return ...;
) }
// 

Signed-off-by: Julia Lawall 

---
 drivers/mmc/host/vub300.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index 3135a1a..6c39bf1 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -2358,9 +2358,9 @@ error5:
 * which is contained at the end of struct mmc
 */
 error4:
-   usb_free_urb(command_out_urb);
-error1:
usb_free_urb(command_res_urb);
+error1:
+   usb_free_urb(command_out_urb);
 error0:
return retval;
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] drivers/mmc/host/vub300.c: add missing usb_free_urb

[Julia Lawall]

From: Julia Lawall julia.law...@lip6.fr

Add missing usb_free_urb on failure path after usb_alloc_urb.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// smpl
@km exists@
local idexpression e;
expression e1,e2,e3;
type T,T1;
identifier f;
@@

* e = usb_alloc_urb(...)
... when any
when != e = e1
when != e1 = (T)e
when != e1(...,(T)e,...)
when != e-f
if(...) { ... when != e2(...,(T1)e,...)
 when != e3 = e
 when forall
(
 return +...e...+;
|
* return ...;
) }
// /smpl

Signed-off-by: Julia Lawall julia.law...@lip6.fr

---
 drivers/mmc/host/vub300.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index 3135a1a..6c39bf1 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -2358,9 +2358,9 @@ error5:
 * which is contained at the end of struct mmc
 */
 error4:
-   usb_free_urb(command_out_urb);
-error1:
usb_free_urb(command_res_urb);
+error1:
+   usb_free_urb(command_out_urb);
 error0:
return retval;
 }

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/