Re: [PATCH 2/2] of: Restrict DMA configuration

2017-08-25 Thread Christoph Hellwig
On Tue, Aug 15, 2017 at 09:19:50AM -0500, Rob Herring wrote: > > For the immediate issue at hand, I guess the alternative plan of attack > > would be to stick a flag in struct bus_type for the bus drivers > > themselves to opt into generic DMA configuration. That at least keeps > > everything withi

Re: [PATCH 2/2] of: Restrict DMA configuration

2017-08-15 Thread Rob Herring
On Tue, Aug 15, 2017 at 5:18 AM, Robin Murphy wrote: > On 14/08/17 21:08, Rob Herring wrote: >> +linuxppc-dev >> >> On Fri, Aug 11, 2017 at 11:29 AM, Robin Murphy wrote: >>> Moving DMA configuration to happen later at driver probe time had the >>> unnoticed side-effect that we now perform DMA con

Re: [PATCH 2/2] of: Restrict DMA configuration

2017-08-15 Thread Robin Murphy
On 14/08/17 21:08, Rob Herring wrote: > +linuxppc-dev > > On Fri, Aug 11, 2017 at 11:29 AM, Robin Murphy wrote: >> Moving DMA configuration to happen later at driver probe time had the >> unnoticed side-effect that we now perform DMA configuration for *every* >> device represented in DT, rather t

Re: [PATCH 2/2] of: Restrict DMA configuration

2017-08-14 Thread Rob Herring
+linuxppc-dev On Fri, Aug 11, 2017 at 11:29 AM, Robin Murphy wrote: > Moving DMA configuration to happen later at driver probe time had the > unnoticed side-effect that we now perform DMA configuration for *every* > device represented in DT, rather than only those explicitly created by > the of_p

Re: [PATCH 2/2] of: Restrict DMA configuration

2017-08-11 Thread Christoph Hellwig
On Fri, Aug 11, 2017 at 05:29:57PM +0100, Robin Murphy wrote: > The good news is that DT already gives us the ammunition to do the right > thing - anything lacking a "dma-ranges" property should be considered > not to have a mapping of DMA address space from its children to its > parent, thus anyth

[PATCH 2/2] of: Restrict DMA configuration

2017-08-11 Thread Robin Murphy
Moving DMA configuration to happen later at driver probe time had the unnoticed side-effect that we now perform DMA configuration for *every* device represented in DT, rather than only those explicitly created by the of_platform and PCI code. As Christoph points out, this is not really the best th