Re: [PATCH 2/3] ARM: dts: sun8i: add audio codec support into V3s DTSI

[Icenowy Zheng]

于 2018年2月3日 GMT+08:00 上午3:49:35, Maxime Ripard  写到:
>On Fri, Feb 02, 2018 at 10:01:52PM +0800, Icenowy Zheng wrote:
>> Allwinner V3s SoC features an internal audio codec like the one in
>H3,
>> and a analog codec like the one in H3/A23 (but much simpler).
>> 
>> Add them in the DTSI file.
>> 
>> Signed-off-by: Icenowy Zheng 
>> ---
>>  arch/arm/boot/dts/sun8i-v3s.dtsi | 19 +++
>>  1 file changed, 19 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi
>b/arch/arm/boot/dts/sun8i-v3s.dtsi
>> index 20edebd983f0..f6c534efaef9 100644
>> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
>> @@ -354,6 +354,25 @@
>>  status = "disabled";
>>  };
>>  
>> +codec: codec@01c22c00 {
>> +#sound-dai-cells = <0>;
>> +compatible = "allwinner,sun8i-v3s-codec";
>> +reg = <0x01c22c00 0x400>;
>> +interrupts = ;
>> +clocks = < CLK_BUS_CODEC>, < CLK_AC_DIG>;
>> +clock-names = "apb", "codec";
>> +resets = < RST_BUS_CODEC>;
>> +dmas = < 15>, < 15>;
>> +dma-names = "rx", "tx";
>> +allwinner,codec-analog-controls = <_analog>;
>> +status = "disabled";
>> +};
>> +
>> +codec_analog: codec-analog@01c23000 {
>> +compatible = "allwinner,sun8i-v3s-codec-analog";
>> +reg = <0x01c23000 0x4>;
>
>This should be the whole size of the memory region.

OK. (Although on the datasheet digital part and analog
part is listed as one region.)

>
>Maxime

Re: [PATCH 2/3] ARM: dts: sun8i: add audio codec support into V3s DTSI

[Icenowy Zheng]

于 2018年2月3日 GMT+08:00 上午3:49:35, Maxime Ripard  写到:
>On Fri, Feb 02, 2018 at 10:01:52PM +0800, Icenowy Zheng wrote:
>> Allwinner V3s SoC features an internal audio codec like the one in
>H3,
>> and a analog codec like the one in H3/A23 (but much simpler).
>> 
>> Add them in the DTSI file.
>> 
>> Signed-off-by: Icenowy Zheng 
>> ---
>>  arch/arm/boot/dts/sun8i-v3s.dtsi | 19 +++
>>  1 file changed, 19 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi
>b/arch/arm/boot/dts/sun8i-v3s.dtsi
>> index 20edebd983f0..f6c534efaef9 100644
>> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
>> @@ -354,6 +354,25 @@
>>  status = "disabled";
>>  };
>>  
>> +codec: codec@01c22c00 {
>> +#sound-dai-cells = <0>;
>> +compatible = "allwinner,sun8i-v3s-codec";
>> +reg = <0x01c22c00 0x400>;
>> +interrupts = ;
>> +clocks = < CLK_BUS_CODEC>, < CLK_AC_DIG>;
>> +clock-names = "apb", "codec";
>> +resets = < RST_BUS_CODEC>;
>> +dmas = < 15>, < 15>;
>> +dma-names = "rx", "tx";
>> +allwinner,codec-analog-controls = <_analog>;
>> +status = "disabled";
>> +};
>> +
>> +codec_analog: codec-analog@01c23000 {
>> +compatible = "allwinner,sun8i-v3s-codec-analog";
>> +reg = <0x01c23000 0x4>;
>
>This should be the whole size of the memory region.

OK. (Although on the datasheet digital part and analog
part is listed as one region.)

>
>Maxime

Re: [PATCH 2/3] ARM: dts: sun8i: add audio codec support into V3s DTSI

[Maxime Ripard]

On Fri, Feb 02, 2018 at 10:01:52PM +0800, Icenowy Zheng wrote:
> Allwinner V3s SoC features an internal audio codec like the one in H3,
> and a analog codec like the one in H3/A23 (but much simpler).
> 
> Add them in the DTSI file.
> 
> Signed-off-by: Icenowy Zheng 
> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 19 +++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi 
> b/arch/arm/boot/dts/sun8i-v3s.dtsi
> index 20edebd983f0..f6c534efaef9 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -354,6 +354,25 @@
>   status = "disabled";
>   };
>  
> + codec: codec@01c22c00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun8i-v3s-codec";
> + reg = <0x01c22c00 0x400>;
> + interrupts = ;
> + clocks = < CLK_BUS_CODEC>, < CLK_AC_DIG>;
> + clock-names = "apb", "codec";
> + resets = < RST_BUS_CODEC>;
> + dmas = < 15>, < 15>;
> + dma-names = "rx", "tx";
> + allwinner,codec-analog-controls = <_analog>;
> + status = "disabled";
> + };
> +
> + codec_analog: codec-analog@01c23000 {
> + compatible = "allwinner,sun8i-v3s-codec-analog";
> + reg = <0x01c23000 0x4>;

This should be the whole size of the memory region.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com


signature.asc
Description: PGP signature

Re: [PATCH 2/3] ARM: dts: sun8i: add audio codec support into V3s DTSI

[Maxime Ripard]

On Fri, Feb 02, 2018 at 10:01:52PM +0800, Icenowy Zheng wrote:
> Allwinner V3s SoC features an internal audio codec like the one in H3,
> and a analog codec like the one in H3/A23 (but much simpler).
> 
> Add them in the DTSI file.
> 
> Signed-off-by: Icenowy Zheng 
> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 19 +++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi 
> b/arch/arm/boot/dts/sun8i-v3s.dtsi
> index 20edebd983f0..f6c534efaef9 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -354,6 +354,25 @@
>   status = "disabled";
>   };
>  
> + codec: codec@01c22c00 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun8i-v3s-codec";
> + reg = <0x01c22c00 0x400>;
> + interrupts = ;
> + clocks = < CLK_BUS_CODEC>, < CLK_AC_DIG>;
> + clock-names = "apb", "codec";
> + resets = < RST_BUS_CODEC>;
> + dmas = < 15>, < 15>;
> + dma-names = "rx", "tx";
> + allwinner,codec-analog-controls = <_analog>;
> + status = "disabled";
> + };
> +
> + codec_analog: codec-analog@01c23000 {
> + compatible = "allwinner,sun8i-v3s-codec-analog";
> + reg = <0x01c23000 0x4>;

This should be the whole size of the memory region.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com


signature.asc
Description: PGP signature

[PATCH 2/3] ARM: dts: sun8i: add audio codec support into V3s DTSI

[Icenowy Zheng]

Allwinner V3s SoC features an internal audio codec like the one in H3,
and a analog codec like the one in H3/A23 (but much simpler).

Add them in the DTSI file.

Signed-off-by: Icenowy Zheng 
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index 20edebd983f0..f6c534efaef9 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -354,6 +354,25 @@
status = "disabled";
};
 
+   codec: codec@01c22c00 {
+   #sound-dai-cells = <0>;
+   compatible = "allwinner,sun8i-v3s-codec";
+   reg = <0x01c22c00 0x400>;
+   interrupts = ;
+   clocks = < CLK_BUS_CODEC>, < CLK_AC_DIG>;
+   clock-names = "apb", "codec";
+   resets = < RST_BUS_CODEC>;
+   dmas = < 15>, < 15>;
+   dma-names = "rx", "tx";
+   allwinner,codec-analog-controls = <_analog>;
+   status = "disabled";
+   };
+
+   codec_analog: codec-analog@01c23000 {
+   compatible = "allwinner,sun8i-v3s-codec-analog";
+   reg = <0x01c23000 0x4>;
+   };
+
uart0: serial@1c28000 {
compatible = "snps,dw-apb-uart";
reg = <0x01c28000 0x400>;
-- 
2.15.1

[PATCH 2/3] ARM: dts: sun8i: add audio codec support into V3s DTSI

[Icenowy Zheng]

Allwinner V3s SoC features an internal audio codec like the one in H3,
and a analog codec like the one in H3/A23 (but much simpler).

Add them in the DTSI file.

Signed-off-by: Icenowy Zheng 
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index 20edebd983f0..f6c534efaef9 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -354,6 +354,25 @@
status = "disabled";
};
 
+   codec: codec@01c22c00 {
+   #sound-dai-cells = <0>;
+   compatible = "allwinner,sun8i-v3s-codec";
+   reg = <0x01c22c00 0x400>;
+   interrupts = ;
+   clocks = < CLK_BUS_CODEC>, < CLK_AC_DIG>;
+   clock-names = "apb", "codec";
+   resets = < RST_BUS_CODEC>;
+   dmas = < 15>, < 15>;
+   dma-names = "rx", "tx";
+   allwinner,codec-analog-controls = <_analog>;
+   status = "disabled";
+   };
+
+   codec_analog: codec-analog@01c23000 {
+   compatible = "allwinner,sun8i-v3s-codec-analog";
+   reg = <0x01c23000 0x4>;
+   };
+
uart0: serial@1c28000 {
compatible = "snps,dw-apb-uart";
reg = <0x01c28000 0x400>;
-- 
2.15.1