Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-15 Thread Lorenzo Pieralisi
[CC'ed Gustavo] On Fri, Mar 09, 2018 at 09:53:24AM +0530, Vignesh R wrote: > > > On Tuesday 06 March 2018 08:42 PM, Lorenzo Pieralisi wrote: > > On Thu, Feb 15, 2018 at 09:59:21AM +0530, Vignesh R wrote: > >> Hi, > >> > >> On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: > >>> On

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-15 Thread Lorenzo Pieralisi
[CC'ed Gustavo] On Fri, Mar 09, 2018 at 09:53:24AM +0530, Vignesh R wrote: > > > On Tuesday 06 March 2018 08:42 PM, Lorenzo Pieralisi wrote: > > On Thu, Feb 15, 2018 at 09:59:21AM +0530, Vignesh R wrote: > >> Hi, > >> > >> On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: > >>> On

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-08 Thread Vignesh R
On Tuesday 06 March 2018 08:42 PM, Lorenzo Pieralisi wrote: > On Thu, Feb 15, 2018 at 09:59:21AM +0530, Vignesh R wrote: >> Hi, >> >> On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: >>> On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: We need to ensure that there are

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-08 Thread Vignesh R
On Tuesday 06 March 2018 08:42 PM, Lorenzo Pieralisi wrote: > On Thu, Feb 15, 2018 at 09:59:21AM +0530, Vignesh R wrote: >> Hi, >> >> On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: >>> On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: We need to ensure that there are

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-06 Thread Lorenzo Pieralisi
On Thu, Feb 15, 2018 at 09:59:21AM +0530, Vignesh R wrote: > Hi, > > On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: > > On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: > >> We need to ensure that there are no pending MSI IRQ vector set (i.e > >> PCIE_MSI_INTR0_STATUS

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-06 Thread Lorenzo Pieralisi
On Thu, Feb 15, 2018 at 09:59:21AM +0530, Vignesh R wrote: > Hi, > > On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: > > On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: > >> We need to ensure that there are no pending MSI IRQ vector set (i.e > >> PCIE_MSI_INTR0_STATUS

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-01 Thread Lorenzo Pieralisi
On Thu, Mar 01, 2018 at 09:01:53PM +0530, Vignesh R wrote: > Hi Lorenzo, > > On 15-Feb-18 9:59 AM, Vignesh R wrote: > > Hi, > > > > On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: > >> On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: > >>> We need to ensure that there are

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-01 Thread Lorenzo Pieralisi
On Thu, Mar 01, 2018 at 09:01:53PM +0530, Vignesh R wrote: > Hi Lorenzo, > > On 15-Feb-18 9:59 AM, Vignesh R wrote: > > Hi, > > > > On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: > >> On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: > >>> We need to ensure that there are

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-01 Thread Vignesh R
Hi Lorenzo, On 15-Feb-18 9:59 AM, Vignesh R wrote: > Hi, > > On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: >> On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: >>> We need to ensure that there are no pending MSI IRQ vector set (i.e >>> PCIE_MSI_INTR0_STATUS reads 0 at

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-03-01 Thread Vignesh R
Hi Lorenzo, On 15-Feb-18 9:59 AM, Vignesh R wrote: > Hi, > > On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: >> On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: >>> We need to ensure that there are no pending MSI IRQ vector set (i.e >>> PCIE_MSI_INTR0_STATUS reads 0 at

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-02-14 Thread Vignesh R
Hi, On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: > On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: >> We need to ensure that there are no pending MSI IRQ vector set (i.e >> PCIE_MSI_INTR0_STATUS reads 0 at least once) before exiting >> dra7xx_pcie_msi_irq_handler().

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-02-14 Thread Vignesh R
Hi, On Monday 12 February 2018 11:28 PM, Lorenzo Pieralisi wrote: > On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: >> We need to ensure that there are no pending MSI IRQ vector set (i.e >> PCIE_MSI_INTR0_STATUS reads 0 at least once) before exiting >> dra7xx_pcie_msi_irq_handler().

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-02-12 Thread Lorenzo Pieralisi
On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: > We need to ensure that there are no pending MSI IRQ vector set (i.e > PCIE_MSI_INTR0_STATUS reads 0 at least once) before exiting > dra7xx_pcie_msi_irq_handler(). Else, the dra7xx PCIe wrapper will not > register new MSI IRQs even though

Re: [PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-02-12 Thread Lorenzo Pieralisi
On Fri, Feb 09, 2018 at 05:34:14PM +0530, Vignesh R wrote: > We need to ensure that there are no pending MSI IRQ vector set (i.e > PCIE_MSI_INTR0_STATUS reads 0 at least once) before exiting > dra7xx_pcie_msi_irq_handler(). Else, the dra7xx PCIe wrapper will not > register new MSI IRQs even though

[PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-02-09 Thread Vignesh R
We need to ensure that there are no pending MSI IRQ vector set (i.e PCIE_MSI_INTR0_STATUS reads 0 at least once) before exiting dra7xx_pcie_msi_irq_handler(). Else, the dra7xx PCIe wrapper will not register new MSI IRQs even though PCIE_MSI_INTR0_STATUS shows IRQs are pending. Therefore, keep

[PATCH 2/3] PCI: dwc: pci-dra7xx: Improve MSI IRQ handling

2018-02-09 Thread Vignesh R
We need to ensure that there are no pending MSI IRQ vector set (i.e PCIE_MSI_INTR0_STATUS reads 0 at least once) before exiting dra7xx_pcie_msi_irq_handler(). Else, the dra7xx PCIe wrapper will not register new MSI IRQs even though PCIE_MSI_INTR0_STATUS shows IRQs are pending. Therefore, keep