Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Fri, 13 Oct 2017 15:06:09 +0200 Petr Mladek wrote: > > > > Can we even have !PRINTK && EARLY_PRINTK? If so it seems to me continued > > usage of early_printk() is what makes most sense. > > Yes, !PRINTK && EARLY_PRINTK is possible at the moment. It makes some > sense

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Fri, 13 Oct 2017 15:06:09 +0200 Petr Mladek wrote: > > > > Can we even have !PRINTK && EARLY_PRINTK? If so it seems to me continued > > usage of early_printk() is what makes most sense. > > Yes, !PRINTK && EARLY_PRINTK is possible at the moment. It makes some > sense because EARLY_PRINTK

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Fri, Oct 13, 2017 at 03:06:09PM +0200, Petr Mladek wrote: > Or we should call early_printk() from printk() also when > PRINTK is disabled. This. > > Do you mean if someone were to toggle force_early_printk at runtime? > > Or that someone unregisters the early console. That's broken anyway,

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Fri, Oct 13, 2017 at 03:06:09PM +0200, Petr Mladek wrote: > Or we should call early_printk() from printk() also when > PRINTK is disabled. This. > > Do you mean if someone were to toggle force_early_printk at runtime? > > Or that someone unregisters the early console. That's broken anyway,

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu 2017-10-12 13:39:49, Peter Zijlstra wrote: > On Thu, Oct 12, 2017 at 12:24:19PM +0200, Petr Mladek wrote: > > On Thu 2017-09-28 14:18:25, Peter Zijlstra wrote: > > > > +#ifdef CONFIG_EARLY_PRINTK > > > +struct console *early_console; > > > + > > > +static bool __read_mostly

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu 2017-10-12 13:39:49, Peter Zijlstra wrote: > On Thu, Oct 12, 2017 at 12:24:19PM +0200, Petr Mladek wrote: > > On Thu 2017-09-28 14:18:25, Peter Zijlstra wrote: > > > > +#ifdef CONFIG_EARLY_PRINTK > > > +struct console *early_console; > > > + > > > +static bool __read_mostly

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu, Oct 12, 2017 at 12:24:19PM +0200, Petr Mladek wrote: > On Thu 2017-09-28 14:18:25, Peter Zijlstra wrote: > > +#ifdef CONFIG_EARLY_PRINTK > > +struct console *early_console; > > + > > +static bool __read_mostly force_early_printk; > > + > > +static int __init force_early_printk_setup(char

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu, Oct 12, 2017 at 12:24:19PM +0200, Petr Mladek wrote: > On Thu 2017-09-28 14:18:25, Peter Zijlstra wrote: > > +#ifdef CONFIG_EARLY_PRINTK > > +struct console *early_console; > > + > > +static bool __read_mostly force_early_printk; > > + > > +static int __init force_early_printk_setup(char

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu 2017-09-28 14:18:25, Peter Zijlstra wrote: > Add add the 'force_early_printk' kernel parameter to override printk() > and force it into early_printk(). This bypasses all the cruft and fail > from printk() and makes things work again. > > Signed-off-by: Peter Zijlstra (Intel)

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu 2017-09-28 14:18:25, Peter Zijlstra wrote: > Add add the 'force_early_printk' kernel parameter to override printk() > and force it into early_printk(). This bypasses all the cruft and fail > from printk() and makes things work again. > > Signed-off-by: Peter Zijlstra (Intel) > --- >

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu, 28 Sep 2017 14:18:25 +0200 Peter Zijlstra wrote: > Add add the 'force_early_printk' kernel parameter to override printk() > and force it into early_printk(). This bypasses all the cruft and fail > from printk() and makes things work again. Probably break this up

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu, 28 Sep 2017 14:18:25 +0200 Peter Zijlstra wrote: > Add add the 'force_early_printk' kernel parameter to override printk() > and force it into early_printk(). This bypasses all the cruft and fail > from printk() and makes things work again. Probably break this up into two patches. One

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On 09/28/17 09:07, Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 08:41:37AM -0700, Randy Dunlap wrote: > >> Please add that kernel parameter to >> Documentation/admin-guide/kernel-parameters.txt. > > Something like so? Yes, thanks. Ack. > ---

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On 09/28/17 09:07, Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 08:41:37AM -0700, Randy Dunlap wrote: > >> Please add that kernel parameter to >> Documentation/admin-guide/kernel-parameters.txt. > > Something like so? Yes, thanks. Ack. > ---

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu, Sep 28, 2017 at 08:41:37AM -0700, Randy Dunlap wrote: > Please add that kernel parameter to > Documentation/admin-guide/kernel-parameters.txt. Something like so? --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -1165,6

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On Thu, Sep 28, 2017 at 08:41:37AM -0700, Randy Dunlap wrote: > Please add that kernel parameter to > Documentation/admin-guide/kernel-parameters.txt. Something like so? --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -1165,6

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On 09/28/17 05:18, Peter Zijlstra wrote: Hi Peter, Please add that kernel parameter to Documentation/admin-guide/kernel-parameters.txt. thanks, -- ~Randy

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

On 09/28/17 05:18, Peter Zijlstra wrote: Hi Peter, Please add that kernel parameter to Documentation/admin-guide/kernel-parameters.txt. thanks, -- ~Randy

[PATCH 2/3] early_printk: Add force_early_printk kernel parameter

Add add the 'force_early_printk' kernel parameter to override printk() and force it into early_printk(). This bypasses all the cruft and fail from printk() and makes things work again. Signed-off-by: Peter Zijlstra (Intel) --- kernel/printk/printk.c | 68

[PATCH 2/3] early_printk: Add force_early_printk kernel parameter

Add add the 'force_early_printk' kernel parameter to override printk() and force it into early_printk(). This bypasses all the cruft and fail from printk() and makes things work again. Signed-off-by: Peter Zijlstra (Intel) --- kernel/printk/printk.c | 68

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

d-by. In particular, the above change was moved to the first patch to fix bisectability. The result after applying both patches is still exactly the same. >From e1c00ae67d07767ec8e5bddb1113c2badf31f4bd Mon Sep 17 00:00:00 2001 From: Petr Mladek <pmla...@suse.com> Date: Tue, 29 Nov 2

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

d-by. In particular, the above change was moved to the first patch to fix bisectability. The result after applying both patches is still exactly the same. >From e1c00ae67d07767ec8e5bddb1113c2badf31f4bd Mon Sep 17 00:00:00 2001 From: Petr Mladek Date: Tue, 29 Nov 2016 13:32:56 +0100 Subject: [PAT

[PATCH 2/3] early_printk: Add force_early_printk kernel parameter

Add add the 'force_early_printk' kernel parameter to override printk() and force it into early_printk(). This bypasses all the cruft and fail from printk() and makes things work again. Signed-off-by: Peter Zijlstra (Intel) --- kernel/printk/printk.c | 74

[PATCH 2/3] early_printk: Add force_early_printk kernel parameter

Add add the 'force_early_printk' kernel parameter to override printk() and force it into early_printk(). This bypasses all the cruft and fail from printk() and makes things work again. Signed-off-by: Peter Zijlstra (Intel) --- kernel/printk/printk.c | 74