Re: [PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-16 Thread Ravi Bangoria
Thanks Jiri for the reviews. Will post v2 soon. -Ravi On 04/13/2018 06:28 PM, Jiri Olsa wrote: > On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote: > > SNIP > >> - !remove_name_list_str && !purge_name_list_str && >> - !missing_filename &&

Re: [PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-16 Thread Ravi Bangoria
Thanks Jiri for the reviews. Will post v2 soon. -Ravi On 04/13/2018 06:28 PM, Jiri Olsa wrote: > On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote: > > SNIP > >> - !remove_name_list_str && !purge_name_list_str && >> - !missing_filename &&

Re: [PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-13 Thread Jiri Olsa
On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote: SNIP > - !remove_name_list_str && !purge_name_list_str && > - !missing_filename && !update_name_list_str)) > + opts_flag = add_name_list_str || kcore_filename || > +

Re: [PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-13 Thread Jiri Olsa
On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote: SNIP > - !remove_name_list_str && !purge_name_list_str && > - !missing_filename && !update_name_list_str)) > + opts_flag = add_name_list_str || kcore_filename || > +

Re: [PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-13 Thread Jiri Olsa
On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote: SNIP > int cmd_buildid_cache(int argc, const char **argv) > { > struct strlist *list; > @@ -304,6 +324,8 @@ int cmd_buildid_cache(int argc, const char **argv) > int ret = 0; > int ns_id = -1; > bool force =

Re: [PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-13 Thread Jiri Olsa
On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote: SNIP > int cmd_buildid_cache(int argc, const char **argv) > { > struct strlist *list; > @@ -304,6 +324,8 @@ int cmd_buildid_cache(int argc, const char **argv) > int ret = 0; > int ns_id = -1; > bool force =

Re: [PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-13 Thread Jiri Olsa
On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote: > Perf buildid-cache allows to add/remove files into cache but there > is no option to list all cached files. Add --list option to list > all _valid_ cached files. > > Ex, > # perf buildid-cache --add /tmp/a.out > # perf

Re: [PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-13 Thread Jiri Olsa
On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote: > Perf buildid-cache allows to add/remove files into cache but there > is no option to list all cached files. Add --list option to list > all _valid_ cached files. > > Ex, > # perf buildid-cache --add /tmp/a.out > # perf

[PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-09 Thread Ravi Bangoria
Perf buildid-cache allows to add/remove files into cache but there is no option to list all cached files. Add --list option to list all _valid_ cached files. Ex, # perf buildid-cache --add /tmp/a.out # perf buildid-cache -l /tmp/a.out (8a86ef73e44067bca52cc3f6cd3e5446c783391c)

[PATCH 2/3] perf/buildid-cache: Support --list option

2018-04-09 Thread Ravi Bangoria
Perf buildid-cache allows to add/remove files into cache but there is no option to list all cached files. Add --list option to list all _valid_ cached files. Ex, # perf buildid-cache --add /tmp/a.out # perf buildid-cache -l /tmp/a.out (8a86ef73e44067bca52cc3f6cd3e5446c783391c)