Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default

2018-02-06 Thread Ulf Magnusson
On Tue, Feb 6, 2018 at 8:11 PM, Bjorn Helgaas wrote: >> x86/PCI: VMD: Fix malformed default > > In the title, please include a clue about what default you're talking > about, e.g., mention Kconfig somehow. > > On Mon, Feb 05, 2018 at 02:21:32AM +0100, Ulf Magnusson wrote: >> 'default N' should be

Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default

2018-02-06 Thread Bjorn Helgaas
> x86/PCI: VMD: Fix malformed default In the title, please include a clue about what default you're talking about, e.g., mention Kconfig somehow. On Mon, Feb 05, 2018 at 02:21:32AM +0100, Ulf Magnusson wrote: > 'default N' should be 'default n', though they happen to have the same > effect here,

Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default

2018-02-04 Thread Ulf Magnusson
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson wrote: > 'default N' should be 'default n', though they happen to have the same > effect here, due to undefined symbols (N in this case) evaluating to n > in a tristate sense. > > Remove the default from VMD instead of changing it. bool and tristate >

[PATCH 20/20] x86/PCI: VMD: Fix malformed default

2018-02-04 Thread Ulf Magnusson
'default N' should be 'default n', though they happen to have the same effect here, due to undefined symbols (N in this case) evaluating to n in a tristate sense. Remove the default from VMD instead of changing it. bool and tristate symbols implicitly default to n. Discovered with the https://git