Re: [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor

2016-10-26 Thread Thor Thayer 



On 10/26/2016 07:52 AM, Lee Jones wrote:

On Thu, 13 Oct 2016, ttha...@opensource.altera.com wrote:


From: Thor Thayer 

Add the Altera Arria10 DevKit System Resource Monitor functionality
to the MFD device.

Signed-off-by: Thor Thayer 
---
 drivers/mfd/altera-a10sr.c |4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
index 06e1f7f..0942d7d 100644
--- a/drivers/mfd/altera-a10sr.c
+++ b/drivers/mfd/altera-a10sr.c
@@ -33,6 +33,10 @@
.name = "altr_a10sr_gpio",
.of_compatible = "altr,a10sr-gpio",
},
+   {
+   .name = "altr_a10sr_mon",
+   .of_compatible = "altr,a10sr-mon",


"-monitor" would be better in my opinion.



OK. I'm flexible and it is clearer. I'll make the changes and resubmit.
Thanks for reviewing!


+   },
 };

 static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg)

Re: [PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor

2016-10-26 Thread Lee Jones 
On Thu, 13 Oct 2016, ttha...@opensource.altera.com wrote:

> From: Thor Thayer 
> 
> Add the Altera Arria10 DevKit System Resource Monitor functionality
> to the MFD device.
> 
> Signed-off-by: Thor Thayer 
> ---
>  drivers/mfd/altera-a10sr.c |4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
> index 06e1f7f..0942d7d 100644
> --- a/drivers/mfd/altera-a10sr.c
> +++ b/drivers/mfd/altera-a10sr.c
> @@ -33,6 +33,10 @@
>   .name = "altr_a10sr_gpio",
>   .of_compatible = "altr,a10sr-gpio",
>   },
> + {
> + .name = "altr_a10sr_mon",
> + .of_compatible = "altr,a10sr-mon",

"-monitor" would be better in my opinion.

> + },
>  };
>  
>  static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH 3/4] mfd: altr-a10sr: Add Arria10 SR Monitor

2016-10-13 Thread tthayer 
From: Thor Thayer 

Add the Altera Arria10 DevKit System Resource Monitor functionality
to the MFD device.

Signed-off-by: Thor Thayer 
---
 drivers/mfd/altera-a10sr.c |4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
index 06e1f7f..0942d7d 100644
--- a/drivers/mfd/altera-a10sr.c
+++ b/drivers/mfd/altera-a10sr.c
@@ -33,6 +33,10 @@
.name = "altr_a10sr_gpio",
.of_compatible = "altr,a10sr-gpio",
},
+   {
+   .name = "altr_a10sr_mon",
+   .of_compatible = "altr,a10sr-mon",
+   },
 };
 
 static bool altr_a10sr_reg_readable(struct device *dev, unsigned int reg)
-- 
1.7.9.5