Re: [PATCH 3/4] pm2301-charger: Check return value of regulator_enable

2013-09-04 Thread Lee Jones 
On Mon, 02 Sep 2013, Sachin Kamat wrote:

> Check the return value of regulator_enable to silence the following
> warning:
> drivers/power/pm2301_charger.c:725:20: warning:
> ignoring return value of ‘regulator_enable’, declared with
> attribute warn_unused_result [-Wunused-result]

Same thing here.

> Signed-off-by: Sachin Kamat 
> Cc: Lee Jones 
> ---
>  drivers/power/pm2301_charger.c |7 ++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c
> index ffa10ed..ab87d1a 100644
> --- a/drivers/power/pm2301_charger.c
> +++ b/drivers/power/pm2301_charger.c
> @@ -722,7 +722,12 @@ static int pm2xxx_charger_ac_en(struct ux500_charger 
> *charger,
>  
>   dev_dbg(pm2->dev, "Enable AC: %dmV %dmA\n", vset, iset);
>   if (!pm2->vddadc_en_ac) {
> - regulator_enable(pm2->regu);
> + ret = regulator_enable(pm2->regu);
> + if (ret) {
> + dev_err(pm2->dev,
> + "Failed to enable regulator\n");
> + goto error_occured;
> + }
>   pm2->vddadc_en_ac = true;
>   }
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] pm2301-charger: Check return value of regulator_enable

2013-09-04 Thread Lee Jones 
On Mon, 02 Sep 2013, Sachin Kamat wrote:

 Check the return value of regulator_enable to silence the following
 warning:
 drivers/power/pm2301_charger.c:725:20: warning:
 ignoring return value of ‘regulator_enable’, declared with
 attribute warn_unused_result [-Wunused-result]

Same thing here.

 Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
 Cc: Lee Jones lee.jo...@linaro.org
 ---
  drivers/power/pm2301_charger.c |7 ++-
  1 file changed, 6 insertions(+), 1 deletion(-)
 
 diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c
 index ffa10ed..ab87d1a 100644
 --- a/drivers/power/pm2301_charger.c
 +++ b/drivers/power/pm2301_charger.c
 @@ -722,7 +722,12 @@ static int pm2xxx_charger_ac_en(struct ux500_charger 
 *charger,
  
   dev_dbg(pm2-dev, Enable AC: %dmV %dmA\n, vset, iset);
   if (!pm2-vddadc_en_ac) {
 - regulator_enable(pm2-regu);
 + ret = regulator_enable(pm2-regu);
 + if (ret) {
 + dev_err(pm2-dev,
 + Failed to enable regulator\n);
 + goto error_occured;
 + }
   pm2-vddadc_en_ac = true;
   }
  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] pm2301-charger: Check return value of regulator_enable

2013-09-02 Thread Sachin Kamat 
Check the return value of regulator_enable to silence the following
warning:
drivers/power/pm2301_charger.c:725:20: warning:
ignoring return value of ‘regulator_enable’, declared with
attribute warn_unused_result [-Wunused-result]

Signed-off-by: Sachin Kamat 
Cc: Lee Jones 
---
 drivers/power/pm2301_charger.c |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c
index ffa10ed..ab87d1a 100644
--- a/drivers/power/pm2301_charger.c
+++ b/drivers/power/pm2301_charger.c
@@ -722,7 +722,12 @@ static int pm2xxx_charger_ac_en(struct ux500_charger 
*charger,
 
dev_dbg(pm2->dev, "Enable AC: %dmV %dmA\n", vset, iset);
if (!pm2->vddadc_en_ac) {
-   regulator_enable(pm2->regu);
+   ret = regulator_enable(pm2->regu);
+   if (ret) {
+   dev_err(pm2->dev,
+   "Failed to enable regulator\n");
+   goto error_occured;
+   }
pm2->vddadc_en_ac = true;
}
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] pm2301-charger: Check return value of regulator_enable

2013-09-02 Thread Sachin Kamat 
Check the return value of regulator_enable to silence the following
warning:
drivers/power/pm2301_charger.c:725:20: warning:
ignoring return value of ‘regulator_enable’, declared with
attribute warn_unused_result [-Wunused-result]

Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Lee Jones lee.jo...@linaro.org
---
 drivers/power/pm2301_charger.c |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c
index ffa10ed..ab87d1a 100644
--- a/drivers/power/pm2301_charger.c
+++ b/drivers/power/pm2301_charger.c
@@ -722,7 +722,12 @@ static int pm2xxx_charger_ac_en(struct ux500_charger 
*charger,
 
dev_dbg(pm2-dev, Enable AC: %dmV %dmA\n, vset, iset);
if (!pm2-vddadc_en_ac) {
-   regulator_enable(pm2-regu);
+   ret = regulator_enable(pm2-regu);
+   if (ret) {
+   dev_err(pm2-dev,
+   Failed to enable regulator\n);
+   goto error_occured;
+   }
pm2-vddadc_en_ac = true;
}
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/