Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-23 Thread Nicholas Piggin
On Fri, 23 Sep 2016 13:00:35 +0800 zijun_hu wrote: > On 2016/9/23 11:30, Nicholas Piggin wrote: > > On Fri, 23 Sep 2016 00:30:20 +0800 > > zijun_hu wrote: > > > >> On 2016/9/22 20:37, Michal Hocko wrote: > >>> On Thu 22-09-16 09:13:50, zijun_hu wrote: > On 09/22/2016 08:35 AM, Davi

Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-22 Thread zijun_hu
On 2016/9/23 11:30, Nicholas Piggin wrote: > On Fri, 23 Sep 2016 00:30:20 +0800 > zijun_hu wrote: > >> On 2016/9/22 20:37, Michal Hocko wrote: >>> On Thu 22-09-16 09:13:50, zijun_hu wrote: On 09/22/2016 08:35 AM, David Rientjes wrote: >>> [...] > The intent is as it is implemented;

Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-22 Thread Nicholas Piggin
On Fri, 23 Sep 2016 00:30:20 +0800 zijun_hu wrote: > On 2016/9/22 20:37, Michal Hocko wrote: > > On Thu 22-09-16 09:13:50, zijun_hu wrote: > >> On 09/22/2016 08:35 AM, David Rientjes wrote: > > [...] > >>> The intent is as it is implemented; with your change, lazy_max_pages() is > >>> pote

Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-22 Thread zijun_hu
On 2016/9/22 20:37, Michal Hocko wrote: > On Thu 22-09-16 09:13:50, zijun_hu wrote: >> On 09/22/2016 08:35 AM, David Rientjes wrote: > [...] >>> The intent is as it is implemented; with your change, lazy_max_pages() is >>> potentially increased depending on the number of online cpus. This is >>>

Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-22 Thread Michal Hocko
On Thu 22-09-16 09:13:50, zijun_hu wrote: > On 09/22/2016 08:35 AM, David Rientjes wrote: [...] > > The intent is as it is implemented; with your change, lazy_max_pages() is > > potentially increased depending on the number of online cpus. This is > > only a heuristic, changing it would need jus

Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-21 Thread zijun_hu
On 09/22/2016 08:35 AM, David Rientjes wrote: > On Thu, 22 Sep 2016, zijun_hu wrote: > >> On 2016/9/22 5:21, David Rientjes wrote: >>> On Wed, 21 Sep 2016, zijun_hu wrote: >>> From: zijun_hu correct lazy_max_pages() return value if the number of online CPUs is power of 2

Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-21 Thread David Rientjes
On Thu, 22 Sep 2016, zijun_hu wrote: > On 2016/9/22 5:21, David Rientjes wrote: > > On Wed, 21 Sep 2016, zijun_hu wrote: > > > >> From: zijun_hu > >> > >> correct lazy_max_pages() return value if the number of online > >> CPUs is power of 2 > >> > >> Signed-off-by: zijun_hu > >> --- > >> mm/vm

Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-21 Thread zijun_hu
On 2016/9/22 5:21, David Rientjes wrote: > On Wed, 21 Sep 2016, zijun_hu wrote: > >> From: zijun_hu >> >> correct lazy_max_pages() return value if the number of online >> CPUs is power of 2 >> >> Signed-off-by: zijun_hu >> --- >> mm/vmalloc.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 dele

Re: [PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-21 Thread David Rientjes
On Wed, 21 Sep 2016, zijun_hu wrote: > From: zijun_hu > > correct lazy_max_pages() return value if the number of online > CPUs is power of 2 > > Signed-off-by: zijun_hu > --- > mm/vmalloc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.

[PATCH 3/5] mm/vmalloc.c: correct lazy_max_pages() return value

2016-09-20 Thread zijun_hu
From: zijun_hu correct lazy_max_pages() return value if the number of online CPUs is power of 2 Signed-off-by: zijun_hu --- mm/vmalloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index a125ae8..2804224 100644 --- a/mm/vmalloc.c +++ b/mm/