[PATCH 4/6] perf ui browser: Fixup cleaning unused lines at the bottom

2018-04-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo 

Now that we can have extra title lines we should use ui_browser->rows
and not ->height when drawing lines, as well as adding
ui_browser->extra_title_lines to browser->y when cleaning unused lines
at the bottom, otherwise we end up clobbering with spaces the last line
just shown by ui_browser->refresh() routine.

Cc: Adrian Hunter 
Cc: Andi Kleen 
Cc: David Ahern 
Cc: Jin Yao 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Fixes: ef9ff6017e3c ("perf ui browser: Move the extra title lines from the 
hists browser")
Link: https://lkml.kernel.org/n/tip-dfcpokt1pm5ixm8n9pxwt...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo 
---
 tools/perf/ui/browser.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index d7bb2591838e..4f75561424ed 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -343,8 +343,8 @@ static int __ui_browser__refresh(struct ui_browser *browser)
else
width += 1;
 
-   SLsmg_fill_region(browser->y + row, browser->x,
- browser->height - row, width, ' ');
+   SLsmg_fill_region(browser->y + row + browser->extra_title_lines, 
browser->x,
+ browser->rows - row, width, ' ');
 
return 0;
 }
-- 
2.14.3



[PATCH 4/6] perf ui browser: Fixup cleaning unused lines at the bottom

2018-04-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo 

Now that we can have extra title lines we should use ui_browser->rows
and not ->height when drawing lines, as well as adding
ui_browser->extra_title_lines to browser->y when cleaning unused lines
at the bottom, otherwise we end up clobbering with spaces the last line
just shown by ui_browser->refresh() routine.

Cc: Adrian Hunter 
Cc: Andi Kleen 
Cc: David Ahern 
Cc: Jin Yao 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Cc: Wang Nan 
Fixes: ef9ff6017e3c ("perf ui browser: Move the extra title lines from the 
hists browser")
Link: https://lkml.kernel.org/n/tip-dfcpokt1pm5ixm8n9pxwt...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo 
---
 tools/perf/ui/browser.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index d7bb2591838e..4f75561424ed 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -343,8 +343,8 @@ static int __ui_browser__refresh(struct ui_browser *browser)
else
width += 1;
 
-   SLsmg_fill_region(browser->y + row, browser->x,
- browser->height - row, width, ' ');
+   SLsmg_fill_region(browser->y + row + browser->extra_title_lines, 
browser->x,
+ browser->rows - row, width, ' ');
 
return 0;
 }
-- 
2.14.3