Re: [PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one

2018-05-02 Thread Darrick J. Wong
On Wed, May 02, 2018 at 11:14:45PM +0200, Christoph Hellwig wrote: > If we release the lockdep write protection token before calling into > ->write_iter and thus never access the file pointer after an -EIOCBQUEUED > return from ->write_iter or ->read_iter we don't need this extra > reference. > >

Re: [PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one

2018-05-02 Thread Darrick J. Wong
On Wed, May 02, 2018 at 11:14:45PM +0200, Christoph Hellwig wrote: > If we release the lockdep write protection token before calling into > ->write_iter and thus never access the file pointer after an -EIOCBQUEUED > return from ->write_iter or ->read_iter we don't need this extra > reference. > >

[PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one

2018-05-02 Thread Christoph Hellwig
If we release the lockdep write protection token before calling into ->write_iter and thus never access the file pointer after an -EIOCBQUEUED return from ->write_iter or ->read_iter we don't need this extra reference. Signed-off-by: Christoph Hellwig --- fs/aio.c | 25

[PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one

2018-05-02 Thread Christoph Hellwig
If we release the lockdep write protection token before calling into ->write_iter and thus never access the file pointer after an -EIOCBQUEUED return from ->write_iter or ->read_iter we don't need this extra reference. Signed-off-by: Christoph Hellwig --- fs/aio.c | 25 -

Re: [PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one

2018-04-26 Thread Darrick J. Wong
On Sun, Apr 15, 2018 at 05:01:05PM +0200, Christoph Hellwig wrote: > If we release the lockdep write protection token before calling into > ->write_iter and thus never access the file pointer after an -EIOCBQUEUED > return from ->write_iter or ->read_iter we don't need this extra > reference.

Re: [PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one

2018-04-26 Thread Darrick J. Wong
On Sun, Apr 15, 2018 at 05:01:05PM +0200, Christoph Hellwig wrote: > If we release the lockdep write protection token before calling into > ->write_iter and thus never access the file pointer after an -EIOCBQUEUED > return from ->write_iter or ->read_iter we don't need this extra > reference.

[PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one

2018-04-15 Thread Christoph Hellwig
If we release the lockdep write protection token before calling into ->write_iter and thus never access the file pointer after an -EIOCBQUEUED return from ->write_iter or ->read_iter we don't need this extra reference. Signed-off-by: Christoph Hellwig --- fs/aio.c | 11 +--

[PATCH 4/7] aio: remove the extra get_file/fput pair in io_submit_one

2018-04-15 Thread Christoph Hellwig
If we release the lockdep write protection token before calling into ->write_iter and thus never access the file pointer after an -EIOCBQUEUED return from ->write_iter or ->read_iter we don't need this extra reference. Signed-off-by: Christoph Hellwig --- fs/aio.c | 11 +-- 1 file