4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Wei Yongjun <weiyongj...@huawei.com>


[ Upstream commit 76e28f5ffed82b1e81a86c4eb8d0420515765620 ]

Fix to return error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 5a2a30024d8c ("gpio: Add gpio driver support for ThunderX and OCTEON-TX")
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
Acked-by: David Daney <david.da...@cavium.com>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
Signed-off-by: Sasha Levin <alexander.le...@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/gpio/gpio-thunderx.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/gpio/gpio-thunderx.c
+++ b/drivers/gpio/gpio-thunderx.c
@@ -566,8 +566,10 @@ static int thunderx_gpio_probe(struct pc
        txgpio->irqd = 
irq_domain_create_hierarchy(irq_get_irq_data(txgpio->msix_entries[0].vector)->domain,
                                                   0, 0, 
of_node_to_fwnode(dev->of_node),
                                                   &thunderx_gpio_irqd_ops, 
txgpio);
-       if (!txgpio->irqd)
+       if (!txgpio->irqd) {
+               err = -ENOMEM;
                goto out;
+       }
 
        /* Push on irq_data and the domain for each line. */
        for (i = 0; i < ngpio; i++) {


Reply via email to