Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0

2018-03-08 Thread Greg Kroah-Hartman
On Thu, Mar 08, 2018 at 09:48:08PM +0100, Jacek Anaszewski wrote: > On 03/08/2018 06:24 PM, Greg Kroah-Hartman wrote: > > On Wed, Mar 07, 2018 at 09:39:08PM +0100, Jacek Anaszewski wrote: > >> Hi Ben, > >> > >> On 03/07/2018 04:32 PM, Ben Hutchings wrote: > >>> On Fri, 2018-03-02 at 09:51 +0100, Gr

Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0

2018-03-08 Thread Jacek Anaszewski
On 03/08/2018 06:24 PM, Greg Kroah-Hartman wrote: > On Wed, Mar 07, 2018 at 09:39:08PM +0100, Jacek Anaszewski wrote: >> Hi Ben, >> >> On 03/07/2018 04:32 PM, Ben Hutchings wrote: >>> On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote: 4.4-stable review patch. If anyone has any objec

Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0

2018-03-08 Thread Pavel Machek
e refers to a LED_BLINK_SW flag which is not used in 4.4. So > > > this fix probably isn't needed, though I can't tell whether it does any > > > harm. > > > > We discussed it in [0]. This patch is not needed for 4.4 and what's > > more more it is har

Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0

2018-03-08 Thread Greg Kroah-Hartman
On Wed, Mar 07, 2018 at 09:39:08PM +0100, Jacek Anaszewski wrote: > Hi Ben, > > On 03/07/2018 04:32 PM, Ben Hutchings wrote: > > On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote: > >> 4.4-stable review patch. If anyone has any objections, please let me > >> know. > >> > >>

Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0

2018-03-07 Thread Jacek Anaszewski
Hi Ben, On 03/07/2018 04:32 PM, Ben Hutchings wrote: > On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote: >> 4.4-stable review patch. If anyone has any objections, please let me >> know. >> >> -- >> >> From: Matthieu CASTET >> >> >> [ Upstream commit 2b83ff96f51d0b039c4

Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0

2018-03-07 Thread Ben Hutchings
On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me > know. > > -- > > From: Matthieu CASTET > > > [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] > > With the current code, the follo

Re: [PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0

2018-03-07 Thread Ben Hutchings
On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > -- > > From: Matthieu CASTET > > > [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] > > With the current code, the followi

[PATCH 4.4 16/34] led: core: Fix brightness setting when setting delay_off=0

2018-03-02 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Matthieu CASTET [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] With the current code, the following sequence won't work : echo timer > trigger echo 0 > delay_off * at this poin